Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There are missing @param
entries within the hook_migrate_prepare_row
documentation, and there is also no documentation for hook_migrate_MIGRATION_ID_prepare_row()
.
I suggest that these are both added.
Comment | File | Size | Author |
---|---|---|---|
#4 | patch_result_core.png | 19.62 KB | Venkatesh Rajan.J |
#2 | 2931368-2.patch | 1.81 KB | opdavies |
Comments
Comment #2
opdaviesThis patch adds the missing
@param
entries, and also the example code forhook_migrate_MIGRATION_ID_prepare_row()
. I've used the same code fromhook_migrate_prepare_row()
, removing only the if statement for$migration->id()
as that is not needed, but I'm happy to use different example code if needed.Comment #3
Venkatesh Rajan.J CreditAttribution: Venkatesh Rajan.J as a volunteer and at DrupalPartners commentedComment #4
Venkatesh Rajan.J CreditAttribution: Venkatesh Rajan.J as a volunteer and at DrupalPartners commented@opdavies,
Thanks for the patch. Your patch applied cleanly. PFA for the same.
Comment #5
catch@Venkatesh Rajan.J just a note there's no need to upload a screenshot of the patch applying on the CLI, since DrupalCI checks this and reports back if the patch fails on the issue anyway. We don't normally give issue credit for setting an issue to RTBC unless there is a significant review involved, so I'm unassigning credit on this issue but thanks for checking the patch.
Comment #7
catchCommitted 4e5b4b0 and pushed to 8.5.x. Thanks!