Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I consider this to be a bug as it used to have the label and the uninstall page still does. (One of the two is wrong.)
You should be able to click on the module name and have the checkbox be selected.
Patch fixes that.
Comment | File | Size | Author |
---|---|---|---|
#9 | system_module_label.patch | 852 bytes | boombatower |
system_module_label.patch | 850 bytes | boombatower | |
Comments
Comment #1
obsidiandesign CreditAttribution: obsidiandesign commentedPatch works correctly here; both select and deselect of the checkbox occur by clicking on the module name repeatedly, in admin/build/modules and the uninstall page.
Comment #2
boombatower CreditAttribution: boombatower commentedI assume that means. Thanks.
Comment #3
Dries CreditAttribution: Dries commentedThe for-attribute that we generate for those labels are a bit long/verbose:
edit-modules-Core---optional-contact-enable
. Also, given that they include strings from the .info file, have we check that these are escaped properly? Let's talk about this a bit and mark it back to RTBC if that is considered to be best.Comment #4
boombatower CreditAttribution: boombatower commentedIs that out of scope (or change in scope)? Since that is generated based on the field names and such and this patch simply uses it for the label? It is already sent to the page.
I noticed that is was rather long as well and I agree it would seem overly long.
Should we either:
Create a separate issue or change this one.
Commit this issue and then work on id.
Comment #5
kscheirerpatch applies cleanly (7 line offset) and works for me.
The checkbox IDs are kinda long, but that's not this patch's fault. If that gets fixed along with the escaping issue, the labels will use the new values.
Comment #6
catchThis may be a duplicate of #229129: System module page *seriously* broken
Comment #7
boombatower CreditAttribution: boombatower commentedThat issue doesn't contain anything related to this and this is a very small patch.
I think the id issue should be moved to that thread.
Per #5 marking as RTBC.
Comment #8
boombatower CreditAttribution: boombatower commentedping.
Comment #9
boombatower CreditAttribution: boombatower commentedApplied with offset so re-rolled.
Comment #10
boombatower CreditAttribution: boombatower commentedStill applies, and ready to go.
Comment #11
Damien Tournoud CreditAttribution: Damien Tournoud commentedIf I understand correctly, this restores a feature lost by #229129: System module page *seriously* broken:
As such, it is a (very small) but good first step toward restoring the functionality of the modules admin page.
Comment #12
boombatower CreditAttribution: boombatower commentedYes, very small, but as I found this issue before with the uninstall page it would be nice to keep them both working.
Comment #13
Dries CreditAttribution: Dries commentedCommitted. Thanks!
Comment #14
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.