Problem/Motivation

This is spun off from #2876085: Before upgrading, audit for potential ID conflicts, comments #252 to #255.

Right now, the only way to determine if a migration is auditable is to dig into its plugin definition, like so:

$migration->getPluginDefinition()['audit']

This is a leaky abstraction and should be sealed.

Proposed resolution

Add a new method, isAuditable(), to MigrationInterface.

Remaining tasks

Write a patch! Pass the tests! Review the patch! Commit!

User interface changes

None.

API changes

MigrationInterface will receive a new method.

Data model changes

None.

CommentFileSizeAuthor
#3 2930832-3.patch1.71 KBphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima created an issue. See original summary.

larowlan’s picture

Title: [PP-1] Add isAuditable() method to MigrationInterface » Add isAuditable() method to MigrationInterface
Status: Postponed » Active

the blocker is in

phenaproxima’s picture

Status: Active » Needs review
FileSize
1.71 KB

Here we go...

maxocub’s picture

Status: Needs review » Reviewed & tested by the community

This is a nice improvement, +1.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2930832-3.patch, failed testing. View results

Anonymous’s picture

Status: Needs work » Reviewed & tested by the community

Revert status after random fail.

larowlan’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record, +API addition

This qualifies under the 1:1 rule for interfaces, but needs a change record

Thanks

quietone’s picture

Started the change record, just copied and similar one and edited it. Hope it makes it easier to finish.

heddn’s picture

Status: Needs work » Reviewed & tested by the community

CR added. Back to RTBC.

phenaproxima’s picture

Issue tags: -Needs change record

Removing the tag.

heddn’s picture

Issue tags: +Migrate January 2017 Sprint
heddn’s picture

Issue tags: -Migrate January 2017 Sprint +Migrate January 2018 Sprint

  • Gábor Hojtsy committed 8419cf3 on 8.5.x
    Issue #2930832 by phenaproxima, heddn, larowlan, quietone: Add...
Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Edited the change record for various reasons. Eg. the use of "currently" is problematic because when is "currently", when the change record was written or when read :) Also there was a bunch of wrong copy-paste / English issues.

Otherwise agreed with @larowlan above that this looks fine and maps to the 1:1 interface/class rule.

Committed, thanks!

quietone’s picture

@Gábor Hojtsy, thanks. That is so much better. I like the Before/After model, which obviously I didn't write. I just wanted to get the ball rolling.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.