Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
This is spun off from #2876085: Before upgrading, audit for potential ID conflicts, comments #252 to #255.
Right now, the only way to determine if a migration is auditable is to dig into its plugin definition, like so:
$migration->getPluginDefinition()['audit']
This is a leaky abstraction and should be sealed.
Proposed resolution
Add a new method, isAuditable(), to MigrationInterface.
Remaining tasks
Write a patch! Pass the tests! Review the patch! Commit!
User interface changes
None.
API changes
MigrationInterface will receive a new method.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#3 | 2930832-3.patch | 1.71 KB | phenaproxima |
Comments
Comment #2
larowlanthe blocker is in
Comment #3
phenaproximaHere we go...
Comment #4
maxocub CreditAttribution: maxocub as a volunteer commentedThis is a nice improvement, +1.
Comment #6
Anonymous (not verified) CreditAttribution: Anonymous commentedRevert status after random fail.
Comment #7
larowlanThis qualifies under the 1:1 rule for interfaces, but needs a change record
Thanks
Comment #8
quietone CreditAttribution: quietone as a volunteer commentedStarted the change record, just copied and similar one and edited it. Hope it makes it easier to finish.
Comment #9
heddnCR added. Back to RTBC.
Comment #10
phenaproximaRemoving the tag.
Comment #11
heddnComment #12
heddnComment #14
Gábor HojtsyEdited the change record for various reasons. Eg. the use of "currently" is problematic because when is "currently", when the change record was written or when read :) Also there was a bunch of wrong copy-paste / English issues.
Otherwise agreed with @larowlan above that this looks fine and maps to the 1:1 interface/class rule.
Committed, thanks!
Comment #15
quietone CreditAttribution: quietone as a volunteer commented@Gábor Hojtsy, thanks. That is so much better. I like the Before/After model, which obviously I didn't write. I just wanted to get the ball rolling.