Update the module to match the current Drupal coding standards, including:

  • Short array syntax.
  • Remove @file docblock comments.
  • Whitespace.
  • Other things that coder review identifies.
CommentFileSizeAuthor
#3 backup_migrate-n2930752-3.patch220.38 KBDamienMcKenna
#3 backup_migrate-n2930752-3.interdiff.txt184.45 KBDamienMcKenna
#2 short_array_syntax-2930752-2.patch63.73 KBVenkatesh Rajan.J
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Venkatesh Rajan.J created an issue. See original summary.

Venkatesh Rajan.J’s picture

Venkatesh Rajan.J CreditAttribution: Venkatesh Rajan.J as a volunteer and at DrupalPartners commented
Assigned: Venkatesh Rajan.J » Unassigned
Status: Active » Needs review
FileSize
short_array_syntax-2930752-2.patch63.73 KB

Attached Patch

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: Convert module to use short array syntax (new coding standard). » Fix coding standards compliance bugs
Issue summary: View changes
FileSize
backup_migrate-n2930752-3.interdiff.txt184.45 KB
backup_migrate-n2930752-3.patch220.38 KB

There isn't a lot more to do, so lets expand this to cover other coding standards bugs, e.g. @file docblock on namespaced class files, spacing issues, etc. phpcbf can be used to fix these.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Lets compare the results of the patch in #3 against the branch test: https://www.drupal.org/pift-ci-job/834726

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

There are still 1565 coding standards messages to look at.

Incidentally, the branch test has gotten stuck and isn't able to finish. Doh.

Alex Andrascu’s picture

Alex Andrascu CreditAttribution: Alex Andrascu commented

This looks fairly good to me as a starting point. Why don't we get it in ?

  • DamienMcKenna committed 6dfc86f on 8.x-4.x 
    Issue #2930752 by DamienMcKenna, Venkatesh Rajan.J: Fix coding standards...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #2912211: Plan for Backup and Migrate 7.x-3.4
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: Fix coding standards compliance bugs » Fix coding standards compliance bugs (D8)
Status: Needs review » Fixed

Committed. We'll do a follow-on task to further improve the codebase.

Alex Andrascu’s picture

Alex Andrascu CreditAttribution: Alex Andrascu commented

Thank you !

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Follow-on issue: #2935402: Further improve coding standards compliance (D8)

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Related issues: +#2935402: Further improve coding standards compliance (D8)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.