Follow-on from #2930500: add a 'pending' state to the payment_default workflow

CommentFileSizeAuthor
#2 2930502-2.commerce.add-a-helper-method-PaymentisComplete.patch1.17 KBjoachim
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

joachim’s picture

joachim CreditAttribution: joachim at Torchbox commented
Title: add a helper method Payment::isComplete() » add a helper method Payment::isCompleted()
Status: Active » Needs review
FileSize
2930502-2.commerce.add-a-helper-method-PaymentisComplete.patch1.17 KB

Calling this isCompleted() rather than isComplete(), to match the name of the state and also the getCompletedTime / setCompletedTime methods.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Assigned: Unassigned » bojanz
Status: Needs review » Needs work

This is comparing a StateItem field object with a string. Proof that we need a kernel test :)

The state check will also return FALSE for refunded payments, which are also technically complete, so I think we need to check the timestamp instead.

  • bojanz committed 4194826 on 8.x-2.x authored by joachim 
    Issue #2930502 by joachim: add a helper method Payment::isCompleted()
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs work » Fixed

Addressed #3, added a test.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.