Problem/Motivation

In order to prepare for #2775653: JavascriptTests with webDriver we deprecated http status and header assertion on \Drupal\FunctionalJavascriptTests\JSWebAssert, see \Drupal\FunctionalJavascriptTests\WebDriverWebAssert

Sadly we missed some

Proposed resolution

Add them as well:

  • \Behat\Mink\WebAssert::responseHeaderContains
  • \Behat\Mink\WebAssert::responseHeaderNotContains
  • \Behat\Mink\WebAssert::responseHeaderMatches
  • \Behat\Mink\WebAssert::responseHeaderNotMatches

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 phpunit-2928522-3-D8.patch2.3 KBioana apetri
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Related issues: +#2827014: Throw an exception when testing status code or response headers in functional JavaScript tests
ioana apetri’s picture

ioana apetri CreditAttribution: ioana apetri at OPTASY commented
Assigned: Unassigned » ioana apetri

I am going to work on this issue.

ioana apetri’s picture

ioana apetri CreditAttribution: ioana apetri at OPTASY commented
Status: Active » Needs review
FileSize
phpunit-2928522-3-D8.patch2.3 KB

Hello, here is my patch,
Please review.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

We need to ensure to update the change record: https://www.drupal.org/node/2857562 should this be done before or after the commit?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Issue tags: +Needs change record updates

Can be done either, but before preferred.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Issue tags: -Needs change record updates

Done

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: phpunit-2928522-3-D8.patch, failed testing. View results

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs work » Reviewed & tested by the community

Random failure

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

Re-tested

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

Committed 4a338bf and pushed to 8.5.x. Thanks!

  • catch committed 4a338bf on 8.5.x 
    Issue #2928522 by yo30, dawehner: \Drupal\FunctionalJavascriptTests\...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.