Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
See #2909372-14: [PP-1] Fix 'Drupal.Commenting.VariableComment.MissingVar' coding standard for the reason why this child issue was created and #2909364: [meta] Fix 'Drupal.Commenting.VariableComment' coding standard for general instructions about working on Drupal.Commenting.VariableComment coding standard errors.
Comment | File | Size | Author |
---|---|---|---|
#2 | issue-2924780-2.patch | 17.17 KB | zaporylie |
Comments
Comment #2
zaporylieThis patch extracts from #2909372-12: [PP-1] Fix 'Drupal.Commenting.VariableComment.MissingVar' coding standard missing @var annotations for scalars that provide default value.
Comment #3
martin107 CreditAttribution: martin107 as a volunteer commented@zaporylie
Thanks for putting all the work into fixing this and other issues
zaporylie++
The patch still applies.
After a visual inspection of the patch ....Yep all these changes look good to me.
Comment #5
xjmChecked those over; it's easy to see that the correct data type is given in each case and that they're unlikely to allow a different data type (or NULL since they're being initialized to other things).
I opened the file to check this one since it was beyond the context lines:
protected $profile = 'minimal';
So that's correct too.
Committed to 8.5.x, and cherry-picked to 8.4.x as a pure docs improvement. Thanks!