Problem/Motivation

The panels block configuration forms don't expose the block entity itself, but that information might be useful to a person altering the form.

Proposed resolution

Add a addBlock method to the PanelsBlockConfigureFormBase class.

Remaining tasks

  • Review patch
  • Commit
  • Rejoice

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 panels-get_block_in_edit_form-2923939-4.patch712 bytesdrclaw
#3 panels-get_block_in_edit_form-2923939-3.patch1.75 KBdrclaw
panels-get_block_in_edit_form-0.patch712 bytesdrclaw
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drclaw created an issue. See original summary.

drclaw’s picture

drclaw CreditAttribution: drclaw at Fuse Interactive commented
Title: Can't access block entity/configuration when altering panels block configuration forms » Can't access block entity when altering panels block configuration forms
drclaw’s picture

drclaw CreditAttribution: drclaw at Fuse Interactive commented
FileSize
panels-get_block_in_edit_form-2923939-3.patch1.75 KB

Actually I think the method name of getEntity might be better as it matches the similar method on the Block form.

drclaw’s picture

drclaw CreditAttribution: drclaw at Fuse Interactive commented
Issue summary: View changes

Update the issue summary

drclaw’s picture

drclaw CreditAttribution: drclaw at Fuse Interactive commented
Issue summary: View changes
FileSize
panels-get_block_in_edit_form-2923939-4.patch712 bytes

Nope, had it right the first time. The block is a block plugin, not an entity... :|

berliner’s picture

berliner CreditAttribution: berliner commented
Status: Needs review » Reviewed & tested by the community

Patch applies properly and does what is expected. Definitely a +1 for the DX.

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented
Status: Reviewed & tested by the community » Fixed

  • japerry committed 24a1880 on 8.x-4.x 
    Issue #2923939 by drclaw: Can't access block entity when altering panels...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.