Problem/Motivation

Follow up to #2282119: Make the Entity Field API handle field purging. When base fields are using shared storage, NULL values are allowed for the column they occupy. When copying to dedicated table storage for purging, NULL values are not allowed.

Proposed resolution

Only copy field values to dedicated storage if at least one column in the field schema is NOT NULL in the shared table storage.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 2923572-6.patch1.77 KBSam152
#6 2923572-6-TEST_ONLY.patch887 bytesSam152
#2 2923572-2.patch927 bytesSam152
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sam152 created an issue. See original summary.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Active » Needs review
FileSize
2923572-2.patch927 bytes

This does the trick. Lets see if the existing tests pass.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Issue summary: View changes
Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Issue summary: View changes
amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented

Oh wow, this is an interesting edge case..

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
FileSize
2923572-6-TEST_ONLY.patch887 bytes
2923572-6.patch1.77 KB

This test should expose this nicely.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

@Sam152++

The last submitted patch, 6: 2923572-6-TEST_ONLY.patch, failed testing. View results

  • larowlan committed 622d5c4 on 8.5.x 
    Issue #2923572 by Sam152: Account for NULL base field values in shared...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed as 622d5c4 and pushed to 8.5.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.