Answers not consistently normalized

Problem/Motivation

When updating a multi-choice question, I received an error about a mismatch in the number of parameters when writing to the quiz_multichoice_answers table. This was caused because $alternatives['feedback_if_not_chosen']['value'] was set to NULL and so the isset() call was returning FALSE leaving $alternatives['feedback_if_not_chosen'] an array.

Proposed resolution

If $alternatives['feedback_if_not_chosen'] or similar keys are an array, they should be set to a single value regardless of other conditions in order for insert and update functions to work. Rather than using isset(), array_key_exists() can be used when re-setting the value of these keys.

Remaining tasks

• Review patch
• Commit