Mark Settings Tray module as stable

Tagging for my list.

I'm aware of a few outstanding a11y points which have been mentioned in various places, including some issues focused on the layout builder. We need to gather those up, and make separate actionable issues where appropriate.

I've also seen a lot of issues crop up (e.g. in the accessibility tag), where it's clear accessibility is being addressed by the settings tray contributors themselves, which is GREAT :-)

@tedbow:

A11y review & sign-off could be quicker if the maintainer walks me though the architecture, and point out what's been done for a11y already. I was following it during the very early stages, but lost track. In particular, I'm keen to learn how the dialog and off-canvas components differ now that they are separate. Could we find a time to meet in Slack/Skype/Hangouts for this?

🎉

Congrats!

Thanks @Wim Leers and @tedbow!

This seems to be in good shape. We'll look at this again next month. (Marking postponed for now; it can just be set back to RTBC on Feb. 21.)

Talked to catch and larowlan; we agreed we can go ahead with this now. Setting back to RTBC. :)

Adding credit to @Wim Leers here. His contribution on this issue is emoji but he reviewed the other. :)

It would be good to get a last +1 on this since I proposed the latest change and Ted rolled a patch. I pinged @tim.plunkett for a quick look since it touches core block implementations.

I personally don't like having the settings_tray keys in system.module blocks, but there is precedence for "use some optional module's annotation key in a core annotation": the field_ui_base_route flag on entity types.

So given that, I think this is fine. Re-RTBC.

Thanks @tim.plunkett for the confirmation and slightly reluctant signoff. :)

The committers have discussed Settings Tray's status in several previous meetings and again in Slack today, and each time those discussing it were comfortable with Settings Tray being stable once the above issues were resolved, including backporting this between 8.5.0's alpha and beta (i.e. right now).

So let's do this!! ☃️💯💃🏻

Fixed the following on commit:

FILE: ...m/git/maintainer/core/modules/settings_tray/settings_tray.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 12 | WARNING | [x] Unused use statement
 13 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Like so:

diff --git a/core/modules/settings_tray/settings_tray.module b/core/modules/settings_tray/settings_tray.module
index 114b4d9b2c..87b40ac66b 100644
--- a/core/modules/settings_tray/settings_tray.module
+++ b/core/modules/settings_tray/settings_tray.module
@@ -9,8 +9,6 @@
 use Drupal\Core\Routing\RouteMatchInterface;
 use Drupal\Core\Url;
 use Drupal\settings_tray\Block\BlockEntityOffCanvasForm;
-use Drupal\settings_tray\Form\SystemBrandingOffCanvasForm;
-use Drupal\settings_tray\Form\SystemMenuOffCanvasForm;
 use Drupal\block\entity\Block;
 use Drupal\block\BlockInterface;
 

Congratulations @tedbow and contributors!