Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
#2543726: Make $term->parent behave like any other entity reference field, to fix REST and Migrate support and de-customize its Views integration is commited to 8.6. That removes the need for the work-around in TermEntityNormalizer
.
See CR https://www.drupal.org/node/2936675
Proposed resolution
When Drupal 8.6.0 is released, remove TermEntityNormalizer and tag a new release which has drupal:system (>= 8.6.0)
as a dependency in its info.yml file.
Remaining tasks
Patch + wait.
User interface changes
None.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#14 | interdiff.txt | 630 bytes | andypost |
#14 | 2921377-14.patch | 3.51 KB | andypost |
#12 | 2921377-12.patch | 2.9 KB | andypost |
Comments
Comment #2
Wim LeersComment #3
Wim LeersComment #4
Wim LeersComment #5
larowlanI would prefer to do a new release with a requirement on system > 8.5.0 and just remove it in one fell swoop, instead of adding conditional registration.
8.4 will be EOL when 8.5 is out.
Comment #6
andypostI like the idea of new release, it will help better normalizers as well
Comment #7
Wim LeersThat works too!
Comment #8
Wim Leers#2543726: Make $term->parent behave like any other entity reference field, to fix REST and Migrate support and de-customize its Views integration will not ship in 8.5, only in 8.6.
Comment #9
Wim LeersAnd that patch already was committed to 8.6, so there's no explicit blocker anymore. There's just waiting … ~8 months :)
Comment #10
heddnWe can get back to work on this again now that the first alpha for 8.6 was released.
Comment #11
andypost8.6 has more issues raised in #2933777: REST/Serializer improvements in core/contrib make it less suitable for default_content use case
I think better to release alpha 8 for 8.5 core & decide on next alpha in parent issue
Comment #12
andypostIn #3092985-11: Deprecation notice: The entity_type.repository service must be passed to ContentEntityNormalizer::__construct() the same was suggested and 8.6 is gone from supported releases
Comment #13
BerdirLovely.
Comment #14
andypostAlso tuned composer and info files
Comment #15
andypostfixed IS to 8.6 according to https://www.drupal.org/node/2936675
Comment #16
BerdirCommitted.