Split off from #2873881: [meta] Add Change Record to @deprecated for common.inc because these types of issues need to scoped by change record not file.

To determine how to complete this issue see #2873705: Add change records to all @deprecated code

Related change record: https://www.drupal.org/node/2235461

CommentFileSizeAuthor
#2 drupal-2920018-2.patch915 bytessergiuteaca
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tedbow created an issue. See original summary.

sergiuteaca’s picture

sergiuteaca CreditAttribution: sergiuteaca at FFW commented
Status: Active » Needs review
FileSize
drupal-2920018-2.patch915 bytes
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented
Status: Needs review » Reviewed & tested by the community

@sergiuteaca thanks!

I have looked at the related change record and this issues it references

  1. #2207743: Convert element_info() to a service
  2. #2226621: Remove usage of element_info(), element_child() and element_children(). Deprecate element_info_property().
  3. #2393331: Replace the calls to element_info() with the ElementInfo service.

I have confirm the only things deprecated in these patches where the 2 functions in this patch.

The patch looks good.

RTBC 🎉🙌

xjm credited JO0st.

xjm credited Janec.

xjm credited anyaabchiche.

xjm credited billywardrop.

xjm credited davemckain.

xjm credited dinarcon.

xjm credited jyraya.

xjm credited kwhite.

xjm credited mairi.

xjm credited sthomps5.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

Adding the many contributors from #2873881: [meta] Add Change Record to @deprecated for common.inc. :)

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.5.x, and backported to 8.4.x as a documentation improvement. Thanks everyone!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

Belatedly adding credit for @tedbow as a reviewer as well.

  • xjm committed d0e3796 on 8.5.x 
    Issue #2920018 by sergiuteaca, billywardrop, anyaabchiche, Janec, JO0st...

  • xjm committed 0f9bf81 on 8.4.x 
    Issue #2920018 by sergiuteaca, billywardrop, anyaabchiche, Janec, JO0st...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kay_v’s picture

kay_v CreditAttribution: kay_v as a volunteer commented
Parent issue: #2873705: Add change records to all @deprecated code »

Removing parent issue per conversation with @xjm at Drupalcon Nashville Mentored Sprint prep. Her recommendation to do so was based on a few points that made sense to all of us in the discussion, namely:
- so many child issues makes this parent unwieldy
- search filters will allow people needing to refind closed children