Problem/Motivation

Incorrect class comment in BlockContentTypeForm class.

Proposed resolution

The comment line needs to be changed to The block content type entity form. instead of Base form for category edit forms.

Thanks.

CommentFileSizeAuthor
#9 incorrect_class_comment-2919901-9.patch465 bytespasan.gamage
#5 incorrect_class_comment-2919901-5.patch469 bytespasan.gamage
#3 incorrect_class_comment-2919901-3.patch464 bytespasan.gamage
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pasan.gamage created an issue. See original summary.

pasan.gamage’s picture

pasan.gamage CreditAttribution: pasan.gamage at PreviousNext commented
Version: 8.3.x-dev » 8.5.x-dev
pasan.gamage’s picture

pasan.gamage CreditAttribution: pasan.gamage at PreviousNext commented
Status: Active » Needs review
FileSize
incorrect_class_comment-2919901-3.patch464 bytes
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Needs work

+ * Base form for block content forms.

Should that be block content type forms?

pasan.gamage’s picture

pasan.gamage CreditAttribution: pasan.gamage at PreviousNext commented
FileSize
incorrect_class_comment-2919901-5.patch469 bytes
pasan.gamage’s picture

pasan.gamage CreditAttribution: pasan.gamage at PreviousNext commented
Status: Needs work » Needs review
Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Needs review » Reviewed & tested by the community
Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Reviewed & tested by the community » Needs work

Is this actually a base form? Nothing extends it. I think it's THE form.

pasan.gamage’s picture

pasan.gamage CreditAttribution: pasan.gamage at PreviousNext commented
FileSize
incorrect_class_comment-2919901-9.patch465 bytes

Changed comment to The block content type entity form

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Needs work » Needs review
Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

LGTM.

pasan.gamage’s picture

pasan.gamage CreditAttribution: pasan.gamage at PreviousNext commented
Issue summary: View changes

Updated the Proposed resolution in the issue description.

  • larowlan committed d743db4 on 8.5.x 
    Issue #2919901 by pasan.gamage: Incorrect class comment for...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed as d743db4 and pushed to 8.5.x.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.