Hide Drag & drop action while translating

We will need tests for this.

Funny thing, i also thought that we should hide this...

But if we hide that button, we should also disable the drag handles. Either disallow both or none.
For current UX consistency, it makes sense to maximally reduce the UI while translating.

This is now simply first about checking $this->allowReferenceChanges() instead isTranslating.

To hide the drag handlers of the table rows completely i opened #2932334: Hide drag handler while translating

I don't think it's Novice, the order problem of when we initialize translation stuff remains, also needs a test. Maybe we can change allowReferenceChanges() to automatically initialize isTranslating if not.

Adding tests. :)

+++ b/src/Plugin/Field/FieldWidget/ParagraphsWidget.php
@@ -936,25 +936,6 @@ class ParagraphsWidget extends WidgetBase {
-
-    if (!empty($field_state['dragdrop'])) {
-      $elements['#attached']['library'][] = 'paragraphs/paragraphs-dragdrop';
-      //$elements['dragdrop_mode']['#button_type'] = 'primary';
-      $elements['dragdrop'] = $this->buildNestedParagraphsFoDragDrop($form_state, NULL, []);
-      return $elements;
-    }

don't move this part, this needs to be done first. that might already be enough to fix the problem.

if header actions also return the complete button, then we need to move that out of that function into the part that must stay on top.

Hmm finally got it working, not sure if this is the best way, gonna see what happens with testbot. :)

This is what I was thinking. We separate the two cases, which allows us to remove a lot of conditional code.

Haven't tried the tests yet.

Wow looks nice, always wondered why both buttons where built in the same place. :)

Improved tests and added allowReferenceChanges to both buttons. Also added test only patch.

> added allowReferenceChanges to both buttons

I removed that on purpose from the complete button. You can only enter drag and drop mode if references have been allowed, it is not necessary to check that again then. but yes, needed for the other one, looks like I dropped that when refactoring.

Right, it makes sense. Thank you.

Thx, committed. Now ALL buttons are gone while translating. :-)

(Just the regular table drag handles remaining...)