Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This select list appears on admin/config/system/actions page.
Currently it looks like this:
Proposed resolution
- Change default empty option from "Choose an advanced action" to "- Select -" to make it look different from other options.
- Sort options alphabetically.
- Place the select list and button above the actions table.
Comment | File | Size | Author |
---|---|---|---|
#11 | action-dropdown-2917916-11.patch | 1.82 KB | arunkumark |
#8 | action-dropdown-2917916-8.patch | 1.86 KB | arunkumark |
#5 | actions.png | 116.8 KB | arunkumark |
#5 | action-dropdown-2917916-5.patch | 1.85 KB | arunkumark |
Comments
Comment #2
xjmThose all sound like good improvements to me; thanks @Chi.
Comment #3
Chi CreditAttribution: Chi commentedLooks like a perfect novice task.
Comment #4
yoroy CreditAttribution: yoroy at Roy Scholten commentedThanks for opening this followup.
Agreed these 3 are all useful improvements to implement.
Comment #5
arunkumarkI have patched for above issue.
Comment #6
Chi CreditAttribution: Chi commentedSort is not proper choice here because it does not maintain index association. It is not possible to create an action with this select list. Also note that Drupal coding standards do not allow comments to appear after statements. For this particular case this comment seems redundant because the goal of this function is pretty obvious.
Comment #7
Chi CreditAttribution: Chi commentedComment #8
arunkumark@Chi thanks for the suggestions. As per your comment, i have updated the sorting mechanism as asort(Sort an array and maintain index association).
Comment #9
Chi CreditAttribution: Chi commented@arunkumark, I am still thinking that commenting such trivial things is not needed.
Comment #10
yoroy CreditAttribution: yoroy at Roy Scholten commentedLets remove that comment then :)
Comment #11
arunkumarkThe patch was re-rolled with comment cleanup.
Comment #12
Chi CreditAttribution: Chi commentedThanks.
Comment #14
xjmNice work! The form is easier to understand now.
Committed and pushed to 8.5.x. I didn't backport it to 8.4.x since it's a UI change. Thanks everyone!