Problem/Motivation

#2916181: Add link to configure page points to a problem in access checking for the checklistapi.checklists.*

The result of $request_stack->getCurrentRequest() corresponds to the modules page, not to the checklists page as it would if you visited it directly.

Proposed resolution

The safe way to access these attributes is through RouteMatch.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 seo-configure-page.png19.85 KBadriancid
#2 2917760-checklist_access-2.patch2.2 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Status: Active » Needs review
Issue tags: +Needs tests
FileSize
2917760-checklist_access-2.patch2.2 KB
adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
seo-configure-page.png19.85 KB

The patch solve the problem

Now the link is available.

seo

TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Thanks, @tim.plunkett and @adriancid! Committed.

TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden as a volunteer commented
Related issues: +#2916181: Add link to configure page

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.