A small issue turned up while doing some drush commands concerning configuration. PHP throws a lot warnings:

in_array() expects parameter 2 to be array, null given IgnoreFilter.php:85
Invalid argument supplied for foreach() IgnoreFilter.php:89

Since this is rather annoying I made a little patch to fix this. Hope this is of use to anyone else.

CommentFileSizeAuthor
#5 fix-php-warnings-in-drush.patch908 bytesqzmenko
fix-php-warnings-in-drush.patch1.12 KBMPaans
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MPaans created an issue. See original summary.

bircher’s picture

bircher
Location 🇨🇿
CreditAttribution: bircher as a volunteer and at Nuvole for World Food Programme commented

Thanks for the contribution.
This is one way of getting rid of the error, but I think it would be better to make sure the plugin is always initialized properly and that $this->configuration['ignored'] is always an array (empty if not set).

bircher’s picture

bircher
Location 🇨🇿
CreditAttribution: bircher as a volunteer and at Nuvole for World Food Programme commented
Status: Needs review » Needs work

The plugin constructor is the palce to do that.

narasimhan_gobear’s picture

narasimhan_gobear CreditAttribution: narasimhan_gobear commented

We ran into the same problem. It happens whenever no modules are set to be ignored.

qzmenko’s picture

qzmenko
Primary language Russian
Location Novosibirsk
CreditAttribution: qzmenko as a volunteer and at DrupalJedi commented
Status: Needs work » Needs review
FileSize
fix-php-warnings-in-drush.patch908 bytes

Same for me. Patch attached.

Dane Powell’s picture

Dane Powell CreditAttribution: Dane Powell at Acquia commented
Status: Needs review » Reviewed & tested by the community

I can confirm the original issue, and that #5 fixes it. The approach also seems good.

  • bircher committed 4a8107c on 8.x-2.x 
    Issue #2917659 by MPaans, qzmenko: PHP throws warnings from IgnoreFilter...
bircher’s picture

bircher
Location 🇨🇿
CreditAttribution: bircher as a volunteer and at Nuvole for World Food Programme commented
Status: Reviewed & tested by the community » Fixed

Thanks for the contribution.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.