The project's .gitignore gets in the way of committing the dependencies when using xautoload. Modules should not force a specific repository workflow on site builders, so the .gitignore file should be removed.

CommentFileSizeAuthor
#2 sendgrid_integration-n2917080-2.patch148 bytesdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new sendgrid_integration-n2917080-2.patch148 bytes

This removes the file.

perignon’s picture

perignon commented

How about if we just remove the .vendor from the gitignore. I use PHPStorm and that is why the .idea folder is there, I don't want to commit my project folder or have anyone else do the same.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

There are other ways of doing this without using .gitignore: https://help.github.com/articles/ignoring-files/

perignon’s picture

perignon commented

Global gitignore, now isn't that handy.

perignon’s picture

perignon commented
Status: Needs review » Fixed

Committed. Thanks for the patch and tip!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

You're welcome :) Hope you're well.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Fixed » Patch (to be ported)

It needs to go in the 7.x-1.x branch too.

perignon’s picture

perignon commented

Yeah I will go fix 7.x now.

  • Perignon committed 78d922c on 7.x-1.x 
    Issue #2917080 by DamienMcKenna, Perignon: Remove the gitignore file
perignon’s picture

perignon commented
Status: Patch (to be ported) » Fixed

Ported and committed.

Yeah, all is good. Back in NH again.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Thanks.

And doh! I'm back in FL again :-\

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.