No tests are running on 8.x-5.x because coding standards are not passing. I'm currently upgrading my site to drupal 8.4 and have some issues with linkit dialog tests which I assume will hit this module as well.

CommentFileSizeAuthor
#2 2915618-phpcs.patch2.78 KBacbramley
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

acbramley created an issue. See original summary.

acbramley’s picture

acbramley CreditAttribution: acbramley at PreviousNext for Transport for NSW commented
Status: Active » Needs review
FileSize
2915618-phpcs.patch2.78 KB
anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented

Thanks for the patch. It works well. However I am also having issues with the dialog tests now. Does not matter if linkit is patched (with your patch) or not.

acbramley’s picture

acbramley CreditAttribution: acbramley at PreviousNext for Transport for NSW commented

@anon is this the issue you're having https://www.drupal.org/node/2831506#comment-12297530?

  • anon committed 565d244 on 8.x-5.x 
    Issue #2915618 by anon: Fix coding standards (practice)
  • anon committed a0c02de on 8.x-5.x authored by acbramley
    Issue #2915618 by acbramley: Fix coding standards so tests run
anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented
Status: Needs review » Fixed

Then I guess this issue can be marked as fixed.

I applied your patch, and also fixed some other practice notices.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.