Problem/Motivation
minimal_install()
updates two configuration files as part of the installation. This is not necessary. The ConfigInstaller
will prefer config in the profile's config/install directory.
In #2788777: Allow a site-specific profile to be installed from existing config we're trying to allow sites to be completely installed from configuration. Whilst module's implementations of hook_install() have to be compatible with being installed via the ConfigImporter
at the moment there is no requirement for install profile's implementations to be because they will always be installed prior to running an import.
Proposed resolution
- Remove
minimal_install()
- Create necessary config files in minimal/config/install
- Add tests to ensure configuration is correct
Remaining tasks
User interface changes
None
API changes
None - a hook implementation is not API.
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#2 | 2914379-2.patch | 2.98 KB | alexpott |
Comments
Comment #2
alexpottHere's a patch
Comment #3
alexpottComment #4
borisson_This looks solid.
Comment #5
Gábor HojtsyComment #7
Gábor HojtsyMakes total sense. This would be best practice also. Committed to 8.5.x. While I don't think this would break anything in 8.4.x, not 100% sure this is eligible for backport. (I *think* it may be since it only ever affects new sites).
Comment #9
cilefen CreditAttribution: cilefen commented#3000677: Fatal error after upgrade to 8.6x [due to regression in extension system]