When running unit testing I get
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors

This is solved after adding migrate_source_csv.data_types.schema.yml

(Couldn't find any opened issue related to this)

CommentFileSizeAuthor
#10 interdiff_8-10.txt365 bytesheddn
#10 2913592-10.patch20.68 KBheddn
#8 interdiff_6-8.txt747 bytesheddn
#8 2913592-8.patch20.68 KBheddn
#6 interdiff_3-6.txt510 bytesheddn
#6 2913592-6.patch19.23 KBheddn
#3 interdiff_2-3.patch16.93 KBheddn
#3 2913592.patch19.25 KBheddn
#2 missing_schema-2913592-2.patch2.67 KBRoySegall
missing_schema.patch1.44 KBordavidil
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ordavidil created an issue. See original summary.

RoySegall’s picture

RoySegall CreditAttribution: RoySegall commented
FileSize
missing_schema-2913592-2.patch2.67 KB

@ordavidil good work, you patch fixed 99% of the issue. I'll post my patch which the problem for me.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
FileSize
2913592.patch19.25 KB
interdiff_2-3.patch16.93 KB

This does less than the previous patch, but also passes tests. Not sure if the tests are lacking or if it will serve.

The last submitted patch, 3: 2913592.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 3: interdiff_2-3.patch, failed testing. View results

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Needs work » Needs review
FileSize
2913592-6.patch19.23 KB
interdiff_3-6.txt510 bytes

Status: Needs review » Needs work

The last submitted patch, 6: 2913592-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Needs work » Needs review
FileSize
2913592-8.patch20.68 KB
interdiff_6-8.txt747 bytes

Fixes phpcs. Not sure why the tests are failing. But something is printing an empty new line. "/n".

Status: Needs review » Needs work

The last submitted patch, 8: 2913592-8.patch, failed testing. View results

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Needs work » Needs review
FileSize
2913592-10.patch20.68 KB
interdiff_8-10.txt365 bytes

There was a leading new line in the test .module file. This should now pass. I found this by adding a testNothing function and disabling modules in the list of enabled modules. Then I started reviewing that module's code.

  • heddn committed 7a49df2 on 8.x-2.x 
    Issue #2913592 by heddn, ordavidil, RoySegall: Missing schema
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Needs review » Fixed
quietone’s picture

quietone CreditAttribution: quietone at Acro Commerce commented

@heddn, Just came here to work on this as you asked. Thanks for getting it done!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.