The destination upload does not exist [#2913362]

After upgrading to the beta 1 version I get this error when I try to restore a database backup, ie at line 131 of file lib/backup_migrate_core/src/Main/BackupMigrate.php

Short look at the code/diff:

In backup_migrate.module these lines were removed:

    // Add an upload destination
    $destinations->add('upload', new \BackupMigrate\Drupal\Destination\DrupalBrowserUploadDestination(new Config(['name' => t('Upload')])));

In src/Form/BackupMigrateRestoreForm.php there's still this line:

  public function submitForm(array &$form, FormStateInterface $form_state) {
    $config = $form_state->getValues();
    backup_migrate_perform_restore($config['source_id'], 'upload', 'backup_migrate_restore_upload', $config);
  }

Comment	File	Size	Author
#10	2913362-destination-upload.patch	731 bytes	Dinu R.
#10	8.x-4.x: PHP 7.1 & MySQL 5.5, D8.3 No tests found
#6	Screenshot_13.png	15.98 KB	zheleong
#3	ScreenHunter-375.jpg	39 KB	fietserwin
#3	ScreenHunter-374.jpg	38.1 KB	fietserwin
#3	ScreenHunter-373.jpg	25.05 KB	fietserwin

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

2 October 2017 at 19:35

fietserwin created an issue. See original summary.

Comment #2

Alex Andrascu CreditAttribution: Alex Andrascu at Intellix commented 3 October 2017 at 14:22

Priority:

Major

» Normal

I don't seem to be able to replicate this. Have tried with several backup files from Saved backups both before and after the upgrade. Have also tried uploading a backup and restoring from that.

Can you please post the full error and also let us know what sort of restore are you trying to do (from upload or from the saved backups). What destination did you use for that particular backup file ? Is anyone else able to replicate this issue ?

Comment #3

fietserwin

Le Mont-Dore

CreditAttribution: fietserwin commented 4 October 2017 at 08:16

File	Size
ScreenHunter-373.jpg	25.05 KB
ScreenHunter-374.jpg	38.1 KB
ScreenHunter-375.jpg	39 KB

Step 1: make a backup and download it to my own computer:

Step 2: Try to restore from a local file:

Step 3: error message:

Note: restoring those 2 lines from backup_migrate.module solves the problem for me, bu they are not in the beta1 version.

Comment #4

4 October 2017 at 12:34

Alex Andrascu committed 2643518 on 8.x-4.x

Issue #2913362 by fietserwin: The destination upload does not exist...

Comment #5

Alex Andrascu CreditAttribution: Alex Andrascu at Intellix commented 4 October 2017 at 12:39

Version:	8.x-4.0-beta1	» 8.x-4.x-dev
Status:	Active	» Fixed

Fixed in beta2. Thank you for reporting it!

Comment #6

zheleong CreditAttribution: zheleong commented 9 October 2017 at 05:09

File	Size
Screenshot_13.png	15.98 KB

Hello, I get another error :
"The file backup_migrate_restore_upload does not exist."

Use :
Drupal core 8.4.0
Backup and Migrate 8.x-4.0-beta2

Thank you

Comment #7

paolo m. CreditAttribution: paolo m. commented 9 October 2017 at 10:02

Hello,
I get the same error: "The file backup_migrate_restore_upload does not exist." with Drupal core 8.4.0 and Backup and Migrate 8.x-4.0-beta2.
Thanks in advance.

Comment #8

finalred CreditAttribution: finalred commented 10 October 2017 at 04:38

same "The file backup_migrate_restore_upload does not exist." Drupal 8.4.0 Backup and Migrate 8.x-4.0-beta2

Comment #9

a65162 CreditAttribution: a65162 commented 10 October 2017 at 09:50

I have the same problem on Drupal 8.40.

Comment #10

Dinu R. CreditAttribution: Dinu R. as a volunteer and at Intellix commented 10 October 2017 at 15:06

Status:

Fixed

» Needs review

File	Size
2913362-destination-upload.patch	731 bytes
8.x-4.x: PHP 7.1 & MySQL 5.5, D8.3 No tests found

Comment #11

Alex Andrascu CreditAttribution: Alex Andrascu at Intellix commented 10 October 2017 at 15:27

Can someone please try this patch and report back ? Thanks.

Comment #12

paolo m. CreditAttribution: paolo m. commented 10 October 2017 at 16:59

Hello,
the patch #10 solved my problems, thank you very much.

I made a test on 3 different sites (all of them had "The file backup_migrate_restore_upload does not exist." issue): Drupal 8.4.0, backup_migrate 8.x-4.0-beta2, db version 5.6.35
2 sites with php 5.6.30,
1 site with php 7.1.6.

Comment #13

Alex Andrascu CreditAttribution: Alex Andrascu at Intellix commented 12 October 2017 at 11:36

Status:

Needs review

» Reviewed & tested by the community

Tested. Looks good.

Comment #14

12 October 2017 at 11:36

Dinu Rodnitchi authored 26e974b on 8.x-4.x

Issue #2913362 by Dinu Rodnitchi, fietserwin, zheleong, Alex Andrascu,...

Comment #15

Alex Andrascu CreditAttribution: Alex Andrascu at Intellix commented 18 October 2017 at 15:26

Status:

Reviewed & tested by the community

» Fixed

Comment #16

Alan D. CreditAttribution: Alan D. commented 20 October 2017 at 03:08

Issue tags:

+8.4.0 update

Tagging to make it easier for people to track these errors :)

Sadly there seems to be a few from 8.3 - 8.4 ...

Comment #17

ikit-claw CreditAttribution: ikit-claw as a volunteer commented 1 November 2017 at 20:38

Status:

Fixed

» Closed (fixed)

Comment #18

Alan D. CreditAttribution: Alan D. commented 2 November 2017 at 01:07

@ikit-claw
Tickets that are flagged as fixed are automatically closed in a couple weeks as part of the default drupal project issue workflow, so there is no need to manually do this ;)