At this moment we always initiate every facet on every request, even if that request does not have any active facet source.
This is intended, as we support showing facets with property only_visible_when_facet_source_is_visible set to false to load on any page.

However, we do not check early enough for this property, which makes us build every facet anyway and trigger for example every url processor for every facet on every page.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

StryKaizer created an issue. See original summary.

StryKaizer’s picture

Status: Active » Needs review
FileSize
645 bytes

Status: Needs review » Needs work

The last submitted patch, 2: do_not_build_facets_for-2913082-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

StryKaizer’s picture

Status: Needs work » Needs review
FileSize
704 bytes
borisson_’s picture

Status: Needs review » Reviewed & tested by the community

This should lead to a huge performance improvement. Thanks!

  • StryKaizer committed 583eaef on 8.x-1.x
    Issue #2913082 by StryKaizer: Do not build facets for every request
    
StryKaizer’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.