Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In the interest of ensuring stability, we need to add some tests.
Specific things to test:
- That enabling the module doesn't break the site :-)
- That the various admin pages load as intended.
- That the admin pages work as intended.
- That backups can be executed.
- That the permissions appropriately limit the functionality.
The first two would be a huge start - make sure the site still works and that the admin pages load, that would be a great base to start from.
Comment | File | Size | Author |
---|---|---|---|
#13 | backup_migrate-n2912460-13.patch | 13.67 KB | DamienMcKenna |
| |||
#13 | backup_migrate-n2912460-13.interdiff.txt | 2.92 KB | DamienMcKenna |
Comments
Comment #2
DamienMcKennaThis needs to be high on the priority list.
Comment #3
DamienMcKennaComment #4
Dinu R. CreditAttribution: Dinu R. as a volunteer and at Intellix commentedAttached patch with basic functional testing
Comment #5
Alex Andrascu CreditAttribution: Alex Andrascu at Intellix commentedComment #6
DamienMcKennaThis is a great start, thank you!
This needs a little polish to make the code match the d.o coding standards, primarily the comments need to wrap at 80 characters and the foreach() statement needs a space after the word "foreach".
Comment #8
Alex Andrascu CreditAttribution: Alex Andrascu at Intellix commentedHi Damien,
I believe I've done the above changes. Can you please review and maybe RTBC. I've already pushed it and will enable the auto testing for the dev branch.
Al.
Comment #9
DamienMcKennaSome refinements for the permissions tests, though it needs finishing off because some of the permissions serve multiple purposes.
Comment #11
DamienMcKennaThere were a few minor bugs related to this:
Comment #13
DamienMcKennaSo the 'access backup and migrate' permission wasn't actually being used either.
Comment #14
DamienMcKennaSo what does everyone think of removing the "delete backup files" permission?
Comment #15
ikit-claw CreditAttribution: ikit-claw as a volunteer commentedSo what does everyone think of removing the "delete backup files" permission?
Is it currently being used or could it be put to good use?
I am a little unsure if it is a good idea or not.
Comment #16
DamienMcKennaI looked through the code again and the "delete" permission isn't actually used.
Comment #17
DamienMcKennaCommitted.