Make media name available on manage display

Discussed briefly with @alexpott and @chr.fritsch, and we decided this will need some sort of test to ensure that we don't accidentally regress the setting later. Something as simple as asserting that the base field is configurable (i.e., in a kernel test) would be sufficient.

+++ b/core/modules/media/tests/src/Kernel/MediaTest.php
@@ -20,4 +20,16 @@ public function testEntity() {
+
...
+
...
+

Looks good. We might want to remove the empty lines but that could probably be done on commit. Or not..

Cleaned it up.

Hm, how is it shown before the patch? As a base field added to the display?

Ok let me do this question differently then :) How is that without changing that twig file, we get it configurable? This is media.html.twig:

<div{{ attributes }}>
  {#
    In the 'full' view mode the entity label is assumed to be displayed as the
    page title, so we do not display it here.
  #}
  {{ title_prefix }}
  {% if label and view_mode != 'full' %}
    <h2{{ title_attributes }}>
      {{ label }}
    </h2>
  {% endif %}
  {{ title_suffix }}

  {{ content }}
</div>

@chr.fritsch rightfully pointed out that the Media class annotation connects the name media field to the label entity key and that leads to the label variable in twig being populated with name. The patch makes it configurable without needing to modify any templates as a consequence.

One more question from here:

+++ b/core/modules/media/src/Entity/Media.php
@@ -404,6 +404,7 @@ public static function baseFieldDefinitions(EntityTypeInterface $entity_type) {
       ->setDisplayConfigurable('form', TRUE)
+      ->setDisplayConfigurable('view', TRUE)

Is this enough as an "upgrade path" for existing sites? We'll definitely not update their active config, so no need to even look into adding the configurable name there, just wondering about whether this makes it possible to add it to the active config on sites that get updated.

Yay, ok, I got it finally. Superb. Committed.

It would be great to have a patch for current 8.4.x too, because the provided patch failed on current version 8.4.0. So I've tried to create a patch for the 8.4.x branch.

Please have a look and sorry if I do something wrong.

Ciao
Ralf

I'm not 100% sure this is allowed on 8.4.x, would need to check with other committers. However the config should definitely not be in the standard profile in 8.4.x.

Hi, I take the config from the 8.5.x branch, so I thought it was ok. The code changes work on 8.4.0. Now I can manage display for the name.

You are right, the config should be situated in the module, so I create a new patch to handle this.

But then the 8.5.x branch should be adapted accordingly, shouldn't it?

No, in 8.5.x the config is in the standard profile following #2883813: Move File/Image media type into Standard once Media is stable.

Ah ok, I didn‘t noticed that. So please have a look at #25 for 8.4.x.

#25 will only apply to 8.4.x, and is not needed in 8.5.x as @Gábor Hojtsy points out, so I'm changing the branch.

I think the patch looks good. I don't think I can RTBC, but if someone else can...

Yep, tested with 8.4.2 and this works just as it should.

Committed as 7a8ffbf and pushed to 8.4.x