Core_search_facets and rest_facets are incorrectly named - they should be "facets_core_search" and "facets_rest".

CommentFileSizeAuthor
#14 rename_sub_modules_to-2911292-14.patch2.9 KBborisson_
#14 interdiff-2911292.txt223 bytesborisson_
#12 rename_sub_modules_to-2911292-12.patch2.9 KBborisson_
#5 rename-sub-modules-2911292-5.patch19.38 KBritzz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented

We'd only want to do this because we want to pas the PAR-bot, and because it's best practice to have the module name be the first part of the submodule names.

Doing this would mean leaving a dummy module with the old name behind - at least for one release.

ritzz’s picture

ritzz CreditAttribution: ritzz at Valuebound commented
Assigned: Unassigned » ritzz
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented

So we have 400+ sites using core search, because this will break their sites, we should also write an upgrade path to move the configuration over.

ritzz’s picture

ritzz CreditAttribution: ritzz at Valuebound commented
Status: Active » Needs review
FileSize
rename-sub-modules-2911292-5.patch19.38 KB

Kindly Review.

Status: Needs review » Needs work

The last submitted patch, 5: rename-sub-modules-2911292-5.patch, failed testing. View results

ritzz’s picture

ritzz CreditAttribution: ritzz at Valuebound commented

I am getting : No such directories error when I applied the patch.
How to resolve it?

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented

Thanks so much for helping out with this issue.

It looks like you only staged the changes after the files are already moved. If you created this from a new branch, it might help to do 

git diff 8.x-1.x >
 patch.patch.

.

If you haven't done this work on a new branch, the easiest solution is to do git log, find the last commit that is on the remote and do a git diff to that. If you have the latest version that is git diff -M b1003c9 > patch.patch.

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Status: Needs work » Postponed

We are discussing moving core_search_facets out of facets and into a new contrib module.
Obviously, is this happens, this patch needs to be rerolled.

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented

Facets core search as separate project in #2911515: Move facets core search into a separate module

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Status: Postponed » Needs work

Needs reroll for facets_rest

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs work » Needs review
FileSize
rename_sub_modules_to-2911292-12.patch2.9 KB
StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Status: Needs review » Needs work

Module is broken
facets_rest.info is not renamed

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs work » Needs review
FileSize
interdiff-2911292.txt223 bytes
rename_sub_modules_to-2911292-14.patch2.9 KB

Renamed yml + actually test it this time.

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Assigned: ritzz » Unassigned
Status: Needs review » Reviewed & tested by the community

  • StryKaizer committed fcd581d on 8.x-1.x authored by borisson_ 
    Issue #2911292 by borisson_, ritzz, StryKaizer: Rename sub modules to...
StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.