When I attempt to migrate a list_float field from d7 to d8, drush tells me
Attempt to create a field storage field_are_you_over_18 with no type. [error]
(/home/matslats/localhost/drupal-8.4.0-rc1/core/modules/field/src/Entity/FieldStorageConfig.php:252)

It seems to me that this mapping has been simply left out of Drupal\options\Plugin\migrate\field\d7\ListField definition, which should read

/**
 * @MigrateField(
 *   id = "list",
 *   type_map = {
 *     "list_boolean" = "boolean",
 *     "list_integer" = "list_integer",
 *     "list_text" = "list_string",
 *     "list_float" = "list_float",
 *   },
 *   core = {7}
 * )
 */
CommentFileSizeAuthor
#11 interdiff-2911288-5-11.txt3.84 KBmaxocub
#11 2911288-11.patch14.16 KBmaxocub
#5 2911288-5.patch12.48 KBmaxocub
#5 2911288-5-test-only.patch11.95 KBmaxocub
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

matslats created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented

@matslats want to add a patch for this? It shouldn't be that hard.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Issue tags: +migrate-d7-d8

Adding tags

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

maxocub’s picture

maxocub CreditAttribution: maxocub as a volunteer commented
Version: 8.5.x-dev » 8.6.x-dev
Status: Active » Needs review
FileSize
2911288-5-test-only.patch11.95 KB
2911288-5.patch12.48 KB

Here's a patch and a failing test.

The last submitted patch, 5: 2911288-5-test-only.patch, failed testing. View results

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Assigned: Unassigned » heddn

I'll try to look at this sometime soon.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Assigned: heddn » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks like we have all 4 of the options now. See https://cgit.drupalcode.org/drupal/tree/modules/field/modules/list/list..... We've got tests! We've got fixes. The fixes look complete. IS is updated. We are good to go.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Parent issue: » #2944605: [META] Check that all field widget types are mapped and tested
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Needs review

This all looks pretty good to me but it seems strange to not add any data to field_data_field_float_list to actually migrate. Shouldn't we add a value to make sue that the migration happens as expected.

maxocub’s picture

maxocub CreditAttribution: maxocub as a volunteer commented
FileSize
2911288-11.patch14.16 KB
interdiff-2911288-5-11.txt3.84 KB

There you go!

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented

@maxocub nice pie!
Credited @matslats for finding and creating the issue.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Fixed

Committed 43645ea and pushed to 8.6.x. Thanks!
Committed 6e4b850 and pushed to 8.5.x. Thanks!

  • alexpott committed 43645ea on 8.6.x 
    Issue #2911288 by maxocub, matslats: No mapping to upgrade list_float...

  • alexpott committed 6e4b850 on 8.5.x 
    Issue #2911288 by maxocub, matslats: No mapping to upgrade list_float...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.