Problem/Motivation

When a user enters an invalid or inaccessible path, they receive an error message that reads:

The path '@path' is either invalid or you do not have access to it.

This sentence is not grammatically correct. Phrases or clauses with "either" need to be parallel in their construction. As written, one possibility is "the path is invalid" and the other is "the path is you do not have access to it". The latter is nonsensical. :)

Proposed resolution

Rewrite the message to use parallel clauses so that it's grammatically correct.

Remaining tasks

As a string change, this issue is no longer eligible for backport to 8.4.x. (We do allow backporting string changes when the message is actually wrong, but in this case fixing the grammar of the English translation does not merit entirely breaking all other translations during RC.)

User interface changes

String now reads:

Either the path '@path' is invalid or you do not have access to it.

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#4 path-2911221-4.patch3.7 KBxjm
#2 path-either.patch3.21 KBxjm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Active » Needs review
Issue tags: +Novice
FileSize
path-either.patch3.21 KB

A novice could review this patch. To review the patch, you can:

  • Confirm that the updated message makes sense.
  • Confirm that the patch fixes all instances of this issue.
  • Take a screenshot of the validation message in the user interface.
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Needs review » Needs work

Oops, except that's text output of a color diff which isn't going to work. One moment.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Needs work » Needs review
FileSize
path-2911221-4.patch3.7 KB
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
dan2k3k4’s picture

dan2k3k4 CreditAttribution: dan2k3k4 at Amazee Labs commented
Status: Needs review » Reviewed & tested by the community

Looks good

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Druid commented
Status: Reviewed & tested by the community » Fixed

The new text makes sense I tried to search using different ways for any existing problems and couldn't find any.

Committed 6054570 and pushed to 8.5.x. Thanks!

  • lauriii committed 6054570 on 8.5.x 
    Issue #2911221 by xjm: Ungrammatical validation message for paths

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.