Coding standards cleanup for Media WYSIWYG submodule, because I wanted to submit a patch to same and there were some coding standards fixes easy to do.

CommentFileSizeAuthor
#2 media-2910372-coding_standards_media_wysiwyg.patch18.63 KBxurizaemon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xurizaemon created an issue. See original summary.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
CreditAttribution: xurizaemon at Catalyst IT commented
Status: Active » Needs review
FileSize
media-2910372-coding_standards_media_wysiwyg.patch18.63 KB

Almost entirely whitespace, here's git show -w

https://gist.github.com/11443e08667851949d4143cdb8b8af64

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

had a quick look, appears good, nice work.
Need to review it a bit more but so far looks great thanks!

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Needs review » Reviewed & tested by the community

should go in soon

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

I took everything EXCEPT for modules/media_wysiwyg/js/wysiwyg-media.js

the javascript changes had some lines of code that were using incorrect spacing or were using tabs instead of spaces. It was mostly ok, but for simplicity sake I took only the files that didn't need massaging.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Reviewed & tested by the community » Fixed

fixed except for modules/media_wysiwyg/js/wysiwyg-media.js
please open a new issue for the coding standards corrections in modules/media_wysiwyg/js/wysiwyg-media.js

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.