Problem/Motivation

There are some parts of the code that don't follow the coding standard and need to be modified.

Proposed resolution

Update the code according to the coding standard.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#5 admin_toolbar-fix_cofing_standar-2909710-5.patch2.11 KBadriancid
#2 admin_toolbar-fix_cofing_standar-2909710-2.patch5.58 KBadriancid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

adriancid created an issue. See original summary.

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer and commented
Assigned: adriancid » Unassigned
Status: Active » Needs review
FileSize
admin_toolbar-fix_cofing_standar-2909710-2.patch5.58 KB
Musa.thomas’s picture

Musa.thomas
Primary language French
Location France 🇫🇷
CreditAttribution: Musa.thomas commented
Status: Needs review » Fixed

Thanks, added into dev version

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer and commented
Status: Fixed » Needs review
FileSize
admin_toolbar-fix_cofing_standar-2909710-5.patch2.11 KB

I think that we should fix this too (see the patch)

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer and commented

@Musa.thomas In a commit here it seems that you accidentally delete some t() calls that seems are need to solve #2759135: Content type, Vocabularies and Menus names are not translated Take a look at https://www.drupal.org/node/2759135#comment-12232369

  • adriancid committed 8c46f06 on 8.x-1.x 
    Issue #2909710 by adriancid, Musa.thomas: Fix coding standard format
adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer and commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.