The duplicate action should not be shown when the add button is hidden.

When translating, it is currently shown inconsistently.

We should also check other actions

CommentFileSizeAuthor
#8 hide_duplicate_action-2909416-8.patch1.53 KBjohnchque
#2 2909416-2.patch656 bytescasey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

miro_dietiker created an issue. See original summary.

casey’s picture

casey CreditAttribution: casey at SWIS commented
Status: Active » Needs review
FileSize
2909416-2.patch656 bytes
johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque commented
Issue tags: +Needs tests

Hmm we will need tests and a test only patch to see that this is working.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Needs review » Needs work
Issue tags: +Usability

Ran into this and it confused me that the action is present indeed.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Parent issue: » #2826631: [META] Duplicate paragraphs
miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Related issues: +#2932344: [META] Hide shared actions when translating
miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Issue tags: +Novice

This is now simply first about checking $this->allowReferenceChanges() instead of isTranslating.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque commented
Status: Needs work » Needs review
FileSize
hide_duplicate_action-2909416-8.patch1.53 KB

With tests. :)

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests

Looks fine.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Novice

Committed, thx.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.