Update from 4.7.2 to CKEditor 4.7.3: http://ckeditor.com/blog/CKEditor-4.7.3-released

4.7.3 contains a whole lot of minor bugfixes: https://ckeditor.com/release/CKEditor-4.7.3.

See also:

#1858210: [meta] Content editing experience follow-ups — in-place editing and WYSIWYG
#1950098: Update CKEditor library to 4.1
#2036253: Update CKEditor library to 4.2
#2039163: Update CKEditor library to 4.4
#2271051: Update CKEditor library to 4.4.4
#2345961: Update CKEditor library to 4.4.5
#2384581: Security: Update CKEditor library to 4.4.6
#2415111: Update CKEditor library to 4.4.7
#2521820: Update CKEditor library to 4.5.3
#2321583: Update CKEditor library to 4.5.5
#2663566: Update CKEditor library to 4.5.7
#2698587: Update CKEditor library to 4.5.8
#2724225: Update CKEditor library to 4.5.9
#2765751: Update CKEditor library to 4.5.10
#2797427: Update CKEditor library to 4.5.11
#2828494: Update CKEditor library to 4.6
#2848215: Update CKEditor library to 4.6.2
#2893566: Update CKEditor library to 4.7.1
#2904142: Update CKEditor library to 4.7.2

CommentFileSizeAuthor
#9 2908864-ckeditor_4.7.3.patch2.9 MBWim Leers
#9 interdiff.txt583 bytesWim Leers
#6 2908864-ckeditor_4.7.3.patch2.9 MBeleleka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Hm, this got the "8.4.0 release notes" tag. Is this actually planned for 8.4.0 (still)?

eleleka’s picture

eleleka CreditAttribution: eleleka at Skilld commented
Assigned: Unassigned » eleleka
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

#2: Yes, just after we'd committed #2904142: Update CKEditor library to 4.7.2 to update Drupal 8.4 to CKEditor 4.7.2, they released version 4.7.3. Ideally, we'd ship 8.4.0 with that version, so that we most likely don't have to update CKEditor during the 8.4 cycle. I hadn't found the time yet to create a patch.

It looks like @eleleka is working on a patch? :)

eleleka’s picture

eleleka CreditAttribution: eleleka at Skilld commented

Yes, gonna push it today

eleleka’s picture

eleleka CreditAttribution: eleleka at Skilld commented
FileSize
2908864-ckeditor_4.7.3.patch2.9 MB
eleleka’s picture

eleleka CreditAttribution: eleleka at Skilld commented
Assigned: eleleka » Unassigned
Status: Active » Needs review
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: -8.4.0 release notes

We're in commit freeze now for 8.4.0, so this will not be in that release. However, as a patch-level update, it can also go in patch releases for 8.4.x: https://www.drupal.org/core/d8-allowed-changes#patch

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community
FileSize
interdiff.txt583 bytes
2908864-ckeditor_4.7.3.patch2.9 MB

Thanks, @eleleka!

Manual testing surfaces no problems.

Only one tiny nitpicky thing was forgotten: updating the license link in core.libraries.yml.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!

  • catch committed 3c76c81 on 8.5.x 
    Issue #2908864 by Wim Leers, eleleka: Update CKEditor library to 4.7.3

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

It may also have a dependency on "sharedspace" plugin. See #2917218: Test to prevent regression between quickedit and ckeditor

cilefen’s picture

cilefen CreditAttribution: cilefen as a volunteer commented
Related issues: +#2920599: CKEditor minifies source in 8.4.1
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Closed (fixed) » Reviewed & tested by the community

Also #2917218: Test to prevent regression between quickedit and ckeditor.

This was a patch-level update, but looks like we can't trust ckeditor patch releases or our own test coverage for quickedit.

I'm going to revert this from both branches and release 8.4.2, we can re-commit it to 8.5.x with test coverage when there's a working patch.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

WTF, how did that happen?! Pinging the CKEditor team.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: 2908864-ckeditor_4.7.3.patch, failed testing. View results

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

Note when we come to re-roll this and commit again to 8.x.x there is #2920599: CKEditor minifies source in 8.4.1 - which seems to report a behaviour change.

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen at Velir commented

I also have a report: https://www.drupal.org/node/2920475

htmlwriter looks like it exists. If there was a change here, where I can view this so I can update the module?

I've asked the reporter to upgrade to 8.4.2 and report back.

cilefen’s picture

cilefen CreditAttribution: cilefen as a volunteer commented
Related issues: +#2920475: "htmlwriter"-plugin not found after updating to drupal core 8.4.1
ericras’s picture

ericras CreditAttribution: ericras at University of Nebraska commented

Also note that the "autogrow" plugin was lost as well in 8.4.1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

I think what we might need is really clear instructions on how to build ckeditor for Drupal. I tried building it using the instructions in core/assets/vendor/ckeditor/build-config.js:

 * You may re-use it at any time at http://ckeditor.com/builder to build
 * CKEditor again. Alternatively, use the "build.sh" script to build it locally.
 * If you do so, be sure to pass it the "-s" flag. So: "sh build.sh -s".

I'm not sure I got the expected result when I used http://ckeditor.com/builder

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen at Velir commented

In #2920475: "htmlwriter"-plugin not found after updating to drupal core 8.4.1 the poster reported that going from 8.4.1 to 8.4.2 fixed the problem. So potentially there could be more CKEditor extension modules in the wild with similar issues on 8.4.1 who need to know they should upgrade to 8.4.2 to fix the immediate problem.

cilefen’s picture

cilefen CreditAttribution: cilefen as a volunteer commented

Also the behavior change noted in #2920599: CKEditor minifies source in 8.4.1 was reverted too.

  • catch committed 355462b on 8.5.x 
    Revert "Issue #2908864 by Wim Leers, eleleka: Update CKEditor library to...
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs work » Closed (won't fix)

We'll skip 4.7.3 and go directly to 4.8.0 in #2926932: Update CKEditor library to 4.8.0 — this also fixes the #2911749: [upstream] CKEditor 4.7 regression: Styles dropdown broken regression that CKEditor 4.7 introduced.