Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
YamlTest::testYamlFiles has a random file_put_contents on the first line. It doesn't do anything and the issue that added it (#2488860: Bring phpunit bridge into drupal and use it for unit tests and simpletest to handle Deprecation) was having trouble with a yaml file but changed nothing about the yaml parser so I assume this was a debug statement that was lost in the review. It didn't even make it into the interdiff by accident.
Writes are pretty expensive too so this might even speed up testbot ever so slightly and save some AWS iops.
Proposed resolution
Remove the code and make testing happy.
Remaining tasks
User interface changes
API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | yamltest_writes-2908600-2.patch | 664 bytes | neclimdul |
Comments
Comment #2
neclimdulpatch
Comment #3
neclimdulComment #4
tim.plunkettComment #5
NickDickinsonWildeConfirmed there are no other references to this extraneously created file.
Comment #6
alexpottI can confirm this was added by #2488860: Bring phpunit bridge into drupal and use it for unit tests and simpletest to handle Deprecation and is not used at at all.
Committed and pushed 2f1622a8c3 to 8.5.x and a5b589fe36 to 8.4.x. Thanks!
Backported to 8.4.x as this is a test-only change.