Replace deprecated \Drupal::entityManager() in EntityReferenceItem

hi,

I have added the updated patch file.

Here in the EntityReferenceItem.php file I have found 11 occurrences of entityManager() which i updated.

Please review.

Here is new updated patch file.

Please review.

Here is a new patch file.

Hope it will work.

Corrected coding standards error: removed unused use statement.

Put back the changes from the patch in #2 that were inexplicably excluded from the patch in #9 (and #10).

Why then not to replace all other calls to entityManager() method? Here is the patch #12 re-roll with replacing all other calls with appropriate services.

Re-rolled patch with correct line endings.

1. +++ b/core/lib/Drupal/Core/Field/Plugin/Field/FieldType/EntityReferenceItem.php
   @@ -414,14 +414,14 @@ public function hasNewEntity() {
   +    $manager = \Drupal::entityTypeManager();
   
   @@ -463,14 +463,14 @@ public static function calculateStorageDependencies(FieldStorageDefinitionInterf
   +    $entity_manager = \Drupal::entityTypeManager();
   

   Let's consistently call these $entity_type_manager

2. +++ b/core/lib/Drupal/Core/Field/Plugin/Field/FieldType/EntityReferenceItem.php
   @@ -414,14 +414,14 @@ public function hasNewEntity() {
   +          $entity = \Drupal::service('entity.repository')->loadEntityByUuid($target_entity_type->id(), $value['target_uuid']);
   
   @@ -463,14 +463,14 @@ public static function calculateStorageDependencies(FieldStorageDefinitionInterf
   +          $entity = \Drupal::service('entity.repository')->loadEntityByUuid($target_entity_type->id(), $value['target_uuid']);
   

   Resolve the service outside the foreach() loops.

3. +++ b/core/modules/views/tests/src/Unit/EntityViewsDataTest.php
   @@ -408,6 +417,12 @@ protected function setupFieldStorageDefinition() {
              ['user', TRUE, static::userEntityInfo()],
            ]
          );
   +    $this->entityTypeManager->expects($this->any())
   +      ->method('getDefinition')
   +      ->willReturnMap([
   +          ['user', TRUE, static::userEntityInfo()],
   +        ]
   +      );
   

   I didn't look very closely at this test, but if we're truly deprecating entity.manager out of the code then we should not mock it in the test. I'm not sure if this test is specific enough one way or another, but if we can remove the entity.manager mock, then we should.

Addressed the test failures by mocking the entity_field.manager service.

1. Consistently used $entity_type_manager.
2. Assigned the entity.repository service outside the loop.
3. entity.manager still needs to be mocked because it is needed elsewhere, e.g. EntityViewsData, while the scope of this issue only covers EntityReferenceItem.

Removed Novice tag because this is quite complicated.

Re-rolled patch against 8.8.x.

Mostly just offsets, but I had to remove one hunk from the patch and change another because those lines were already fixed by out-of-scope changes in #3028671: Add @trigger_error() to deprecated and already (almost) unused EntityManager methods and #3025427: Add @trigger_error() to deprecated EntityManager->EntityTypeBundleInfo methods

issue credits

Committed 37d2299 and pushed to 8.8.x. Thanks!