Problem/Motivation

If you go to the Field List page (admin/reports/fields) will be nice if you can see the entity type where this field is used. Sometimes you can have the same field name in different entity types, so this information can help to fin more quickly the information that you need.

Proposed resolution

Add a new column named Entity type in the Field list page (admin/reports/fields).

Remaining tasks

User interface changes

A new column (Entity type) will be added in the Field list page.

field list

API changes

None.

Data model changes

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

adriancid created an issue. See original summary.

adriancid’s picture

Status: Active » Needs review
FileSize
815 bytes

Status: Needs review » Needs work

The last submitted patch, 2: drupal-add_entity_type_column-2907110-2-D8.patch, failed testing. View results

adriancid’s picture

Status: Needs work » Needs review
munish.kumar’s picture

I have reviewed your code and it Looks good to me.
+1 RTBC

tim.plunkett’s picture

Version: 8.4.x-dev » 8.5.x-dev
Issue tags: +Needs usability review

Thanks! The code looks great, I think this deserves a UX review.

adriancid’s picture

Issue tags: +Usability
Bojhan’s picture

Issue tags: -Needs usability review

Looks good to me. This is very much a developer facing page, I would say the label "entity" here is justified.

adriancid’s picture

@Bojhan What's the next step? We need to change this to RTBC?

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

The code is fine, no sense in writing automated tests, and it was given UX sign off.
RTBC from me!

xjm’s picture

Status: Reviewed & tested by the community » Needs review

Nice improvement!

One suggestion I'd make is making this either the second column, or the second-to-last column. "Used in" specifies bundles, and which bundle it is depends on the entity type, so it seems strange to have the bundle names before the entity type. Since fields can't be shared across entity types, it would make sense for it to be the second column. I think the second column would be best since that would best address the problem statement in the issue summary. If the field name isn't sufficient information, and field name + bundle makes it clearer, it'd be better to have them right next to each other rather than reading all the way to the end of the row.

Four columns across is also a lot on a mobile display. Should we set priorities on some of the columns so that the table is responsive?

adriancid’s picture

@xjm I put it as second column, you're right is better in this place.

The FIELD TYPE column (that is largest) is defined as RESPONSIVE_PRIORITY_MEDIUM, so when you're in mobile devices sometimes is hidden.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

Good change, it fits much better there.

  • xjm committed 2e4eccc on 8.5.x
    Issue #2907110 by adriancid, Bojhan: Add a Entity type column in Field...
xjm’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Fixed
FileSize
75.69 KB

Thanks @adriancid.

The FIELD TYPE column (that is largest) is defined as RESPONSIVE_PRIORITY_MEDIUM, so when you're in mobile devices sometimes is hidden.

Just confirmed this -- here's what it looks like on mobile:

That seems an okay mobile display to me.

Committed and pushed to 8.5.x. Thanks! Also congratulations @adriancid on your second core issue credit. :)

xjm’s picture

Issue summary: View changes
adriancid’s picture

Thanks @xjm and @tim.plunkett :-)

I just see now a typo in the issue title :-O

Add a Entity type column in Field list page

But the commit is done.

Sorry for my english ;-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.