Some of the issues hinted at by https://pareview.sh/node/1196 can be fixed. Not all of them can be.

CommentFileSizeAuthor
#3 fix_parereview_issues-2906665-3.patch24.82 KBborisson_
#3 interdiff-2906665.txt5.35 KBborisson_
#2 fix_parereview_issues-2906665-2.patch20.12 KBborisson_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented
Status: Active » Needs review
FileSize
fix_parereview_issues-2906665-2.patch20.12 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented
FileSize
interdiff-2906665.txt5.35 KB
fix_parereview_issues-2906665-3.patch24.82 KB

  • borisson_ committed c697fe2 on 8.x-1.x 
    Issue #2906665 by borisson_: Fix parereview issues
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented
Status: Needs review » Fixed

Committed this.

  • borisson_ committed 4ea6142 on 8.x-1.x 
    Issue #2906665: Follow-up: Use correct namespace for tests

  • borisson_ committed 28e96fa on 8.x-1.x 
    Issue #2906665: Follow-up, fix more style issues

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.