Problem/Motivation

Items:

----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 7 | ERROR | It's only necessary to declare files[] if they declare a
   |       | class or interface.
 8 | ERROR | It's only necessary to declare files[] if they declare a
   |       | class or interface.
----------------------------------------------------------------------

----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------

----------------------------------------------------------------------
FOUND 19 ERRORS AND 4 WARNINGS AFFECTING 14 LINES
----------------------------------------------------------------------
   1 | ERROR   | [x] Missing file doc comment
  46 | ERROR   | [ ] Missing parameter type
 106 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
     |         |     Implements hook_foo_BAR_ID_bar() for
     |         |     xyz_bar().",, "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.html.twig.",
     |         |     "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.tpl.php.", or "* Implements
     |         |     hook_foo_BAR_ID_bar() for block templates."
 106 | ERROR   | [x] Doc comment short description must end with a
     |         |     full stop
 114 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
     |         |     Implements hook_foo_BAR_ID_bar() for
     |         |     xyz_bar().",, "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.html.twig.",
     |         |     "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.tpl.php.", or "* Implements
     |         |     hook_foo_BAR_ID_bar() for block templates."
 114 | ERROR   | [x] Doc comment short description must end with a
     |         |     full stop
 122 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
     |         |     Implements hook_foo_BAR_ID_bar() for
     |         |     xyz_bar().",, "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.html.twig.",
     |         |     "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.tpl.php.", or "* Implements
     |         |     hook_foo_BAR_ID_bar() for block templates."
 122 | ERROR   | [x] Doc comment short description must end with a
     |         |     full stop
 146 | ERROR   | [ ] Missing parameter type
 148 | ERROR   | [x] Separate the @param and @return sections by a
     |         |     blank line.
 148 | ERROR   | [ ] Return type missing for @return tag in function
     |         |     comment
 186 | ERROR   | [x] No space found before comment text; expected "//
     |         |     function
     |         |     xmlsitemap_taxonomy_calculate_term_priority(stdClass
     |         |     $term) {" but found "//function
     |         |     xmlsitemap_taxonomy_calculate_term_priority(stdClass
     |         |     $term) {"
 186 | ERROR   | [x] Inline comments must start with a capital letter
 191 | WARNING | [x] There must be no blank line following an inline
     |         |     comment
 191 | ERROR   | [x] No space found before comment text; expected "//
     |         |     }" but found "//}"
 191 | ERROR   | [x] Inline comments must end in full-stops,
     |         |     exclamation marks, colons, question marks, or
     |         |     closing parentheses
 196 | ERROR   | [ ] Missing parameter type
 198 | ERROR   | [x] Separate the @param and @return sections by a
     |         |     blank line.
 198 | ERROR   | [ ] Return type missing for @return tag in function
     |         |     comment
 224 | ERROR   | [ ] Missing parameter type
 226 | ERROR   | [x] Separate the @param and @return sections by a
     |         |     blank line.
 226 | ERROR   | [ ] Return type missing for @return tag in function
     |         |     comment
 246 | ERROR   | [ ] If the line declaring an array spans longer than
     |         |     80 characters, each element should be broken
     |         |     into its own line
----------------------------------------------------------------------

----------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 7 LINES
----------------------------------------------------------------------
  8 | ERROR | [x] Missing class doc comment
  9 | ERROR | [ ] Class property $normal_user should use lowerCamel
    |       |     naming without underscores
 12 | ERROR | [x] Missing function doc comment
 20 | ERROR | [x] Missing function doc comment
 20 | ERROR | [x] Visibility must be declared on method "setUp"
 29 | ERROR | [x] Missing function doc comment
 29 | ERROR | [x] Visibility must be declared on method
    |       |     "testTaxonomySettings"
 48 | ERROR | [x] Expected 1 blank line after function; 0 found
 49 | ERROR | [x] The closing brace for the class must have an empty
    |       |     line before it
----------------------------------------------------------------------

Proposed resolution

Fixed items following Drupal Coding Standards and https://www.drupal.org/docs/7/site-building-best-practices/best-practices

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 resolve_all_items-2906594-2.patch6.52 KBrenatog
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RenatoG created an issue. See original summary.

renatog’s picture

Patch with the fix.

  • RenatoG committed d51b2d6 on 7.x-2.x
    Issue #2906594 by RenatoG: Resolve all items Drupal Best practices for...
renatog’s picture

Status: Active » Fixed

Fixed.

Committed to the dev branch.

Regards.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.