Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Repeatable: Always
Expected Results:
Documentation for LockBackendInterface::wait should say that delay must be given in seconds.
Actual Results:
The documentation of LockBackendInterface::wait says that parameter delay should be given in milliseconds whereas in the implementation in LockBackendAbstract delay is used as if it is passed in seconds.
(line 40 in LockBackendAbstract.php says : "..$delay is passed in seconds,..."
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | fix_wrong_unit_in_documentation-2905641-1.patch | 622 bytes | klabowterman |
Comments
Comment #2
klabowterman CreditAttribution: klabowterman at bio.logis Genetic Information Management GmbH commentedpatch attached
Comment #3
klabowterman CreditAttribution: klabowterman at bio.logis Genetic Information Management GmbH commentedComment #4
klabowterman CreditAttribution: klabowterman at bio.logis Genetic Information Management GmbH commentedComment #5
hchonovThe timeout argument of
\Drupal\Core\Lock\LockBackendInterface::acquire()is also given in seconds and the implementation of\Drupal\Core\Lock\LockBackendAbstract::wait()is dealing with the delay parameter as it is given in seconds as well. Therefore the change in the documentation here is correct.Comment #9
catchCommitted/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!