Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
As we converting more entity types to be publishable, in the sense of extending EntityPublishedInterface
, the default Views wizard plugin could simplify the work needed by its subclasses by adding a default filter on the 'published' entity field.
Proposed resolution
Do it.
Remaining tasks
Review.
User interface changes
Nope.
API changes
Nope.
Data model changes
Nope.
Comment | File | Size | Author |
---|---|---|---|
#6 | 2905000-6.patch | 7.53 KB | timmillwood |
#6 | interdiff-2905000-6.txt | 1.55 KB | timmillwood |
Comments
Comment #2
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedIt should be as easy as this patch.
Comment #4
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedAnd this interdiff :)
Comment #5
LendudeNice! Love the unification.
Comment wizard has coverage for this: \Drupal\comment\Tests\Views\WizardTest
Media and media revision have coverage for this : \Drupal\Tests\media\FunctionalJavascript\MediaViewsWizardTest
Node revision has a test but no coverage for this: \Drupal\Tests\node\Functional\Views\NodeRevisionWizardTest
Node wizard doesn't have tests that I see.
So 'needs work' to get the node change covered
Comment #6
timmillwoodImplementing filter assertions in NodeRevisionWizardTest
Comment #7
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedThe test additions look good to me, now we need someone to RTBC this :)
Comment #8
LendudeNew test look perfect, but:
Did somebody recheck this? Did I overlook them or are these still needed? Slightly modified version of
\Drupal\Tests\node\Functional\Views\NodeRevisionWizardTest
would probably be great as base coverage.Comment #9
amateescu CreditAttribution: amateescu for Pfizer, Inc. commented@Lendude, the node wizard is tested in
\Drupal\Tests\views\Functional\Wizard\NodeWizardTest
;)Comment #10
Lendude@amateescu ha! yeah like I said, I may have overlooked that. Silly me, not looking in the Views module for a test for something in the Node module :)
Existing coverage in
\Drupal\Tests\views\Functional\Wizard\NodeWizardTest
looks good. So this is now all covered.Comment #11
larowlanComment #12
larowlanCan we get a change notice here?
Comment #13
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedWould this be enough? https://www.drupal.org/node/2908666
Comment #14
larowlanThanks
Comment #15
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation commentedComment #17
larowlanCommitted as 32e4022 and pushed to 8.5.x.
Published change record
Comment #18
xjmI missed this before but this is a really great change. Great work.
Comment #19
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedThank you :)