The og_notifications module doesn't seem to be upgraded for Drupal 6.

It throws multiple warnings due to not upgraded core hooks and form callbacks, and worst, doesn't work at all.

The attached patch fixes most of the issues, and gets it working.

Please apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

moshe weitzman’s picture

I've asked Zen to take a look at this. Thanks Jose.

moshe weitzman’s picture

I expect the D6 notifications patch to be committed by Zen in the next 48 hours.

webchick’s picture

Status: Active » Needs review

This is a patch.

Also, doesn't look like this was ever committed; HEAD still shows "This version is incompatible with the 6.4 version of Drupal core."

webchick’s picture

Status: Needs review » Needs work

Also, this patch doesn't remotely apply anymore. :(

jackbravo’s picture

FileSize
2.65 KB

This is a PATCH that I'm using and seems to be working. Thanks webchick for pointing this issue, I was on another one (#294818: Warning when enabling Notifications component).

webchick’s picture

Status: Needs work » Needs review

Hey! That one applies. :)

No time to review it now, but cool!

moshe weitzman’s picture

Zen is still working on a patch which makes what we did for 5--3 branch. Thats the one I will commit. Any day now.

dan_aka_jack’s picture

subscribing...

michellezeedru’s picture

subscribing..

michellezeedru’s picture

I just downloaded and installed og 6.x-1.0-rc6
I still get the error:
"warning: Missing argument 1 for og_notifications_menu() in /home/michelle/apache/htdocs/sites/all/modules/og/og_notifications/og_notifications.module on line 15." and Notifications for new nodes created in a group just doesn't work.

What else can I do to get OG notifications working on D6?

zilla’s picture

@mziegmann - seeing the same thing (warning: Missing argument 1 for og_notifications_menu() in /.../html/sites/all/modules/og/og_notifications/og_notifications.module on line 15.)

is this an og-notifications module issue, or perhaps an issue with the notifications module itself?

agentrickard’s picture

FileSize
6.88 KB

Here's a patch against rc6. Seems to be working.

moshe weitzman’s picture

Status: Needs review » Fixed

Zen's patch has already been committed to HEAD.

agentrickard’s picture

Cool.

michellezeedru’s picture

Don't know... but after spending hours and hours trying to get notifications working for OG, I gave up and abandoned both of these modules. Now I'm using Subscriptions and Forums. It isn't exactly what I wanted, but at least it works.

moshe weitzman’s picture

the og_notifications module is simply not done yet. we are heavily working on it. notice that og is not released, and og_notifications is basically in beta. we are down to tweaking data migration stuff now.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

scottrigby’s picture

Status: Closed (fixed) » Active

I disabled and uninstalled the rc6 version, and even after uninstalling I see the same error: warning: Missing argument 1 for og_notifications_menu() in MYSITE/sites/all/modules/og/og_notifications/og_notifications.module on line 15.

I uninstalled because I'd like to install HEAD instead (uninstalled because from other issues, it sounds like there is no path from rc6 to HEAD for table changes etc). But I'm posting about it here because if I'm still seeing this error, I'm concerned that maybe rc6 didn't uninstall completely.

Can anyone help steer me in the right direction here? I'd like to test, and seems the best way is using HEAD for now - but I don't want to test things that we know aren't ready yet - or with a DB that still has lingering info that could skew results.

Thanks :)

jondblackburn’s picture

Hi - If anyone can help, it would be greatly appreciated.

I mistakenly upgraded to d6 w/out checking to see if this functionality still worked in OG. It doesn't apparently, and I need to get it working on a live site. (Okay, it's beta, but people are using it.)

Does any version, patch, etc. of og provide basic e-mail notification functionality? (I noticed when loading up the RC 6 version of OG on a dev server that og does appear to provide a "e-mail notification" option separate from OG Notifications, but it will not show up for my "live" server even after I disable/uninstall og notifications.)

Can I get rc 5 or rc 6 of og to provide basic e-mail subscriptions w/out og notifications?

Any other ideas/hacks/etc.? I am willing to try anything, at this point.

zilla’s picture

well, technically notification for the 'content type' will do it - i'm doing that now - so a 'story' can be posted to site in general or to an OG, so even if you view the story within an OG (which in turn makes the page into an OG page iwth og blocks and all), there is still an option to "subscribe to this post" or "subscribe to posts of type story"

that might work for you until OG notifications is up and running...

Zen’s picture

Status: Active » Closed (fixed)

scott: RC6 very likely did have an upgraded version of og_notifications. Please try to update to the latest version of HEAD on a test installation and see if your issues are sorted. Please open a separate issue if otherwise.
jon, please continue via the other issue.