follow up for #2870009: Update: Convert system functional tests to phpunit

Currently both \Drupal\FunctionalTests\Update\UpdatePathTestBase::setUp and \Drupal\Tests\BrowserTestBase::setUp contain the same code for handling BROWSERTEST_OUTPUT_FILE.

In order to reduce code replication it would be a good idea to move this logic to a method on BrowserTestBase and make both BrowserTestBase and UpdatePathTestBase use this method.

CommentFileSizeAuthor
#3 2904834-3.patch4.72 KBLendude
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Lendude created an issue. See original summary.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Dx Experts commented
Issue tags: +phpunit initiative

tagging

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Dx Experts commented
Status: Active » Needs review
FileSize
2904834-3.patch4.72 KB

So something like this.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Reviewed & tested by the community

Perfect!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2904834-3.patch, failed testing. View results

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Dx Experts commented
Status: Needs work » Reviewed & tested by the community

Unrelated fail

  • larowlan committed 9fe92d9 on 8.5.x 
    Issue #2904834 by Lendude: Move BROWSERTEST_OUTPUT_FILE logic in...

  • larowlan committed 40c0521 on 8.4.x 
    Issue #2904834 by Lendude: Move BROWSERTEST_OUTPUT_FILE logic in...

larowlan credited larowlan.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed as 9fe92d9 and pushed to 8.5.x

Cherry picked as 40c0521 and pushed to 8.4.x

Thanks for the cleanup

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.