Problem/Motivation

The phpdoc for class EmbeddedDataSource gives an example on how to use it in a migration configuration file.
Unfortunately the ids-key in the code example isn't indented correctly which will cause the yaml parser to throw an error
if this snippet is copy-pasted.

see e.g. core/modules/block_content/migration_templates/block_content_type.yml for reference.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pektinasen created an issue. See original summary.

pektinasen’s picture

cilefen’s picture

Category: Task » Bug report
Status: Active » Needs review
Issue tags: -documentation bug +Documentation
jofitz’s picture

Status: Needs review » Reviewed & tested by the community

Good spot! Absolutely correct. Nice, simple docs correction.

Thanks for such a well-written, easy to follow issue - especially the example. Makes it easy to review.

  • catch committed ab03340 on 8.5.x
    Issue #2902287 by pektinasen: Doccomment in EmbeddedDataSource.php not...

  • catch committed 2a96e03 on 8.4.x
    Issue #2902287 by pektinasen: Doccomment in EmbeddedDataSource.php not...

catch credited catch.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.5.x and cherry-picked to 8.4.x, thanks!

kylethebaker’s picture

Glad to see this fixed, I'll go ahead and close this: https://www.drupal.org/node/2889428

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.