Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #2898344: Add filters to the comments administration pages
Problem/Motivation
Provide semantic machine names (instead of mystery IDs) and correct titles (using the correct case and matching the menu tabel labels) of the for the displays comment administration view (newly added in 8.4.x).
Proposed resolution
TBD
Remaining tasks
TBD
User interface changes
Only in the Views UI:
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#13 | interdiff-5-13.txt | 856 bytes | xjm |
#13 | comment-2901778-12.patch | 1.81 KB | xjm |
#6 | dislplay_labeling.png | 216.93 KB | xjm |
#6 | comment-2901778-5.patch | 1002 bytes | xjm |
#5 | interdiff-4-5.txt | 591 bytes | xjm |
Comments
Comment #2
xjmI think we should first change the comment display names since that view was just added in this release and it has two page displays that are semantically different. It's less of an issue for
admin/content
andadmin/people
since they have a single page display.Comment #3
xjmA novice contributor could probably create this patch also!
Comment #4
xjmOkay view display machine names are a pet peeve of mine and it seems especially silly to ship with mystery IDs for a view we just added only to change it later (and not be able to have 8.5.x or whatever match the view on 8.4.x sites), so I rolled the patch myself.
Comment #5
xjmNoticed a related bug while I was in there (the display titles do not match the case of the tabs, which we fixed already in the original patch) and then made the display machine name correlate directly with the user-facing labels.
Comment #6
xjmWith a screenshot to show what it's fixing in the Views UI.
The files admin view has a similar issue with the machine name, but that's less compelling to fix for 8.4.0 by tomorrow since it's been in core since 8.0.0. We wouldn't provide an upgrade path for the file admin view since it could seriously screw with people's custom code, plus we shouldn't be modifying sites' config anyway for such changes (sites own their config, not modules).
Edit: Fixed a fantastically run-on sentence.
Comment #7
xjmComment #10
jibranIt just needs display name updates in
\Drupal\Tests\comment\Kernel\Views\CommentAdminViewTest::testFilters()
Comment #11
jibranI meant these.
Comment #13
xjmThanks @jibran.
Comment #14
jibranPerfect!
Comment #18
catchCommitted/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!