Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Block Field is a useful module when used with Paragraphs.
Currently this works quite well but the collapsed / closed summary is missing.
This patch adds the summary.
Comment | File | Size | Author |
---|---|---|---|
#20 | add_support_for_block-2899322-20.patch | 4.26 KB | yobottehg |
| |||
#16 | add_support_for_block-2899322-16.patch | 4.29 KB | VladimirMarko |
| |||
#16 | interdiff-2899322-13-16.txt | 427 bytes | VladimirMarko |
#16 | add_support_for_block-2899322-16-test-only.patch | 3.59 KB | VladimirMarko |
Comments
Comment #2
yobottehg CreditAttribution: yobottehg commentedComment #3
yobottehg CreditAttribution: yobottehg commentedComment #4
yobottehg CreditAttribution: yobottehg commentedrebased the patch on the latest changes in dev
Comment #5
miro_dietikerYeah, as block field is pretty common, we could add support.
Hopefully we will find a better approach for a generic summary approach.
Pity we can't rely on some generic builtin summary / label functionality.
That said, the magic word to pass the wall is "tests" :-)
Comment #6
VladimirMarko CreditAttribution: VladimirMarko at MD Systems GmbH commentedLet's write some tests.
Comment #7
VladimirMarko CreditAttribution: VladimirMarko at MD Systems GmbH commentedAdded tests.
Comment #10
VladimirMarko CreditAttribution: VladimirMarko at MD Systems GmbH commentedAdded a test dependency to Block Field.
Comment #13
VladimirMarko CreditAttribution: VladimirMarko at MD Systems GmbH commentedAdded a
composer.json
file with test dependencies to Paragraphs.Comment #16
VladimirMarko CreditAttribution: VladimirMarko at MD Systems GmbH commentedAdded regular dependencies to the
composer.json
file.Comment #18
BerdirI don't see why the field name check here is necessary, a block_field is never going to be named like that.
Also, a comment to explain what this does would be good.
Comment #19
yobottehg CreditAttribution: yobottehg commentedI'll fix this copy/pasta from me.
Comment #20
yobottehg CreditAttribution: yobottehg commentedRemoved the field name check, that was copy pasted from the entity_reference field. Added a comment for describing the functionality of the new feature.
Comment #21
BerdirThanks, don't forget to provide an interdiff when updating a patch.
Needs a . at the end of the comment, looks fine otherwise.
Comment #23
miro_dietikerCommitted. :-)