#2896143: Unintentional animation of the body while Settings Tray is installed made me notice a hunk of code at the bottom of outside_in.motion.css that is commented.

It's been commented for as long as it has existed: #2753941: [Experimental] Create Outside In module MVP to provide block configuration in Off-Canvas tray and expand site edit mode.

CommentFileSizeAuthor
#2 2897306-2.patch644 bytesWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Active » Needs review
FileSize
2897306-2.patch644 bytes
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Parent issue: » #2896143: Unintentional animation of the body while Settings Tray is installed
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented
Status: Needs review » Reviewed & tested by the community

Code is commented out. This is no brainer

  • Cottser committed 7dd5ef1 on 8.5.x 
    Issue #2897306 by Wim Leers, tedbow: Remove dead CSS

  • Cottser committed e6f4bee on 8.4.x 
    Issue #2897306 by Wim Leers, tedbow: Remove dead CSS

(cherry picked...

  • Cottser committed e79ba9f on 8.3.x 
    Issue #2897306 by Wim Leers, tedbow: Remove dead CSS

(cherry picked...
star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr at Northern Commerce commented
Version: 8.4.x-dev » 8.5.x-dev
Status: Reviewed & tested by the community » Fixed

Looks good and couldn't find any other commented out CSS.

Committed and pushed to 8.5.x, 8.4.x, 8.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented
Component: outside_in.module » settings_tray.module

Changing to new settings_tray.module component. @drpal thanks for script help! :)