If contact messages are stored (eg. by the "contact_storage" project), their contact form bundle isn't always displayed because the Message entity's annotation doesn't have a bundle_label. Compare with the Node entity.

CommentFileSizeAuthor
#8 drupal-2897204-8-entity-bundle-label.patch1.46 KBcburschka
#2 drupal-2897204-2-contact-message-bundle-label.patch567 bytescburschka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cburschka created an issue. See original summary.

cburschka’s picture

cburschka
they
CreditAttribution: cburschka commented
Status: Active » Needs review
FileSize
drupal-2897204-2-contact-message-bundle-label.patch567 bytes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

+1

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr at Northern Commerce commented

I'm just wondering in terms of issue scoping if this should also handle the shortcut entity since it also seems to be missing a bundle_label.

https://api.drupal.org/api/drupal/core%21modules%21shortcut%21src%21Enti...

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran at PreviousNext commented

Let's create a follow up for that.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr at Northern Commerce commented
Component: contact.module » other
Status: Reviewed & tested by the community » Needs work

Especially because this is minor, let's please take care of both here. It's less overhead :) https://www.drupal.org/core/scope#incomplete

cburschka’s picture

cburschka
they
CreditAttribution: cburschka commented 
$ grep -Rl '@ContentEntityType' core/|xargs grep -l bundle_entity_type|xargs grep -L bundle_label
core//modules/contact/src/Entity/Message.php
core//modules/shortcut/src/Entity/Shortcut.php
core//modules/system/tests/modules/entity_test/src/Entity/EntityTestWithBundle.php

So I can confirm these two types are all we need to fix, assuming we don't need it in the test class.

cburschka’s picture

cburschka
they
CreditAttribution: cburschka commented
Status: Needs work » Needs review
FileSize
drupal-2897204-8-entity-bundle-label.patch1.46 KB

(Leaving on 8.3.x as this is comment-only and introduces no new strings. Patch should apply to 8.4.x and 8.5.x)

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran at PreviousNext commented
Version: 8.3.x-dev » 8.4.x-dev
Component: other » entity system
Status: Needs review » Reviewed & tested by the community

It belongs to entity system now rather than other. We don't have further patch releases for 8.3.x so moving it to 8.4.x

  • catch committed 78ae240 on 8.5.x 
    Issue #2897204 by cburschka: Contact message missing 'bundle_label'...

catch credited catch.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

ommitted/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!

  • catch committed 3d10adb on 8.4.x 
    Issue #2897204 by cburschka: Contact message missing 'bundle_label'...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.