QueryString::buildUrls throws fatal error in facets_system_breadcrumb_alter() when there are no active results.

CommentFileSizeAuthor
#4 facets_system_breadcrumb_alter_2.patch627 bytesarthur_lorenz
facets_system_breadcrumb_alter.patch596 bytesarthur_lorenz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arthur_lorenz created an issue. See original summary.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago at drunomics commented

I'm not sure this fixes the problem in all situations, let's make sure the code works for sure:

$active_results[$facet->getUrlAlias()] could be not set, what leads to NULL to be passed on, what is not valid. So we need to check !empty( $active_results[$facet->getUrlAlias()]) instead of just $active_results.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago at drunomics commented
Status: Needs review » Needs work
arthur_lorenz’s picture

arthur_lorenz CreditAttribution: arthur_lorenz commented
FileSize
facets_system_breadcrumb_alter_2.patch627 bytes

Good point, fixed it.

arthur_lorenz’s picture

arthur_lorenz CreditAttribution: arthur_lorenz commented
Status: Needs work » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented
Status: Needs review » Reviewed & tested by the community

Looks like a really small bugfix, thanks.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.