Javascript error with media browser popup in Adminimal theme

I tried those changes but they didn’t work. I didn’t expect them to because all the problems I’ve encountered have been while logged in as admin.

I have investigated a bit more since posting this report but have not made much progress. As a workaround, I configured the media browser to use the Seven theme. It's not ideal but it worked and it reduced the urgency of trying to find a proper fix.

I don’t know how useful the info below will be, but hopefully it will help.

The error

media.views.js:10 Uncaught ReferenceError: namespace is not defined

refers to the namespace function, which is defined in media.core.js. An issue relating to this file was raised several years ago but is still open:

https://www.drupal.org/node/1123534

I removed the namespacefunction and replaced it with

    Drupal.media.browser.views = Drupal.media.browser.views || {};

as recommended in the above-mentioned issue. It’s also implemented by many other Drupal modules, so I assume the Media module maintainers had good reasons for not implementing it.

Perhaps irrelevant but the patch provided on that page does not patch media.views.js - I don’t know if this is intentional or an oversight.

Back to the problem at hand, the lines (based, admittedly, on copying the syntax of similar files more so than any deep understanding of how the module is structured), replacing the call to the namespace function in media.views.js with this line:

    Drupal.media.browser.views = Drupal.media.browser.views || {};

did not eliminate the error, but adding the following lines did:

    Drupal.media = Drupal.media || {};
    Drupal.media.browser = Drupal.media.browser || {};
    Drupal.media.browser.views = Drupal.media.browser.views || {};

However, then I got the following error:

Uncaught TypeError: Cannot read property 'length' of undefined
    at HTMLIFrameElement.Drupal.media.popups.mediaBrowser.mediaBrowserOnLoad (media.popups.js:137)

At that point I realised I was most likely barking up the wrong tree. It seems unlikely that a module as important and widely used as Media would be released if it contained such a basic error as an undefined function. Even if it was, other people would be reporting the issue too, and nobody did until today.

Next, I created a test site on simplytest.me with Media 7.x-2.9, Adminimal theme 7.x-1.24, and Adminimal admin menu 7.x-1.7. Everything worked perfectly there. Back on my own site, when I tried to use these three modules together I got the errors we’ve both seen.

That’s as far as I’ve got. Even though I haven’t modified the modules, the evidence suggests the problem is related to my environment but whether the root cause is something I've misconfigured, a bug in the Media module, or a bug in Adminimal, remains to be seen. When I get time I will look into it further but I hope someone who knows the module in more detail might see this and offer some guidance.

Hope it helps...

Thanks. I have tried it with every available version of jQuery via jquery_update. Problem is the same in all cases.

I haven't tried the duplicate files module but I don't think there is any need. If there were duplicates I would see them in my git client.

I also have used Adminimal with Media before without any issues but this is the first time I have used it with 7.x-2.9. I will investigate in more detail, do a clean install, try previous versions, compare with working sites, review recent commits etc. but at this stage it's looking like the problem is specific to my environment.

Tried the latest dev release. First I got the namespace error again. Then, when I replaced the namespace function call with these lines:

    Drupal.media = Drupal.media || {};
    Drupal.media.browser = Drupal.media.browser || {};
    Drupal.media.browser.views = Drupal.media.browser.views || {};

I got the same error as before:

Uncaught TypeError: Cannot read property 'length' of undefined
    at HTMLIFrameElement.Drupal.media.popups.mediaBrowser.mediaBrowserOnLoad (media.popups.js?v=7.x-3.0-beta5+1-dev:137)
    at HTMLIFrameElement.dispatch (jquery.min.js?v=1.7.2:3)
    at HTMLIFrameElement.i (jquery.min.js?v=1.7.2:3)

I'm using the Media module with no modifications, Adminimal base theme, no subtheme and I have disabled the Adminimal Admin Menu module which I had been using earlier.
name

Hi Joseph, apologies, I didn't notice the new tagged version. Just tried it - same error:

Uncaught ReferenceError: namespace is not defined
    at media.views.js:10
    at media.views.js:213

I don't understand why media.views.js is not picking up the definition of the namespace function from media.core.js. Since it works everywhere else, and on simplytest.me, it's possible/likely something in my environment is causing the problem. Can't think what it might be - I'll investigate more at the weekend.

Sorry to take so long to reply. In the meantime I have rebuilt the site from scratch (it started off as a site I inherited, with many unnecessary and some deprecated modules). After doing so, the media browser loaded correctly. Unfortunately this leaves me no wiser as to the cause of the error. I guess it was some kind of JavaScript conflict related to the namespace function definition in media.core.js but it was too vague/complicated to debug. Thanks for your help and apologies for having taken up your time.