I am playing with D8 and facets, and noticed that in a clean installation, around 2gb ram, installing facets_range_widget the server struggles a lot. First I have to increase memory in php.ini, then increase the max_time, and finally a time ERR_EMPTY_RESPONSE is shown in the browser.

Simply doing:

drush8 pm-uninstall -y facets_range_widget

"Fixes" the issue, so I assume it is a problem in the module.

CommentFileSizeAuthor
#16 add_testcoverage_for-2894637-16.patch17.91 KBborisson_
#16 interdiff-2894637.txt4.29 KBborisson_
#14 improve_performance_for-2894637-14.patch13.62 KBborisson_
#14 interdiff-2894637.txt2.54 KBborisson_
#12 improve_performance_for-2894637-11.patch11.82 KBborisson_
#12 interdiff-2894637.txt3.64 KBborisson_
#10 interdiff-2894637.txt3.5 KBborisson_
#9 improve_performance_for-2894637-9.patch10.3 KBborisson_
#9 interdiff-2829074.txt883 bytesborisson_
#9 improve_performance_for-2894637-9--widgettest.patch2.49 KBborisson_
#6 facets_range_widget-2894637-6.patch6.8 KBborisson_
#6 interdiff-2894637.txt5.24 KBborisson_
#5 facets_range_widget-2894637-5.patch3.74 KBborisson_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexmoreno created an issue. See original summary.

alexmoreno’s picture

alexmoreno CreditAttribution: alexmoreno commented
Version: 8.x-1.0-alpha1 » 8.x-1.0-alpha10
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Dazzle commented

We've noticed before that ranges with the database backend can be really slow, and as long as we're not yet implementing a solr-specific query it'll be really slow for solr as well. I'd like to know with how many results you're seeing this slowdown. That might help us figure out a way to write a test for this.

alexmoreno’s picture

alexmoreno CreditAttribution: alexmoreno commented

I'm actually using solr, and is a clean db, so not many results). Just 50 nodes for the whole site db created with devel generate, so results can be like 10 or so?

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Dazzle commented
Status: Active » Needs review
FileSize
facets_range_widget-2894637-5.patch3.74 KB

Yeah, that shouldn't be too much for the intended usecase. I've been trying to figure out how to measure this in a test. No clue if this is a good path forward.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Dazzle commented
FileSize
interdiff-2894637.txt5.24 KB
facets_range_widget-2894637-6.patch6.8 KB

Looks like the processor didn't have any specific testcoverage yet. I've tried to increase the amount of results to make this take longer but I can't seem to make it take > 1 second.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Dazzle commented
Title: facets_range_widget performance » Improve performance for range widget + add testcoverage
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Dazzle commented
Version: 8.x-1.0-alpha10 » 8.x-1.x-dev
Status: Needs review » Needs work
Issue tags: +Performance

We should improve the tests to figure out why this is so slow and see if we can reproduce the issue in the test so we know how a solid way to resolve the actual issue.

Needs work for that.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Dazzle commented
Status: Needs work » Needs review
FileSize
improve_performance_for-2894637-9--widgettest.patch2.49 KB
interdiff-2829074.txt883 bytes
improve_performance_for-2894637-9.patch10.3 KB

I figured that maybe it was in the widget, but I can't seem to find it.

I think I found a bug though by writing explicit test coverage.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Dazzle commented
FileSize
interdiff-2894637.txt3.5 KB

Looks like the interdiff in #9 was for a different issue.

borisson_ credited agoradesign.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Dazzle commented
FileSize
interdiff-2894637.txt3.64 KB
improve_performance_for-2894637-11.patch11.82 KB

Crediting agoradesign for review in #2872404: Use native facet range queries with solr + the patch there, that I merged into this patch. This also adds more tests.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Dazzle commented
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Dazzle commented
Title: Improve performance for range widget + add testcoverage » Add testcoverage for range + slider widgets
FileSize
interdiff-2894637.txt2.54 KB
improve_performance_for-2894637-14.patch13.62 KB

Rescoping this issue, created a followup for the actual performance issues.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Dazzle commented
Title: Add testcoverage for range + slider widgets » Add testcoverage for range + slider widgets/processors
Issue tags: -Performance
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Dazzle commented
FileSize
interdiff-2894637.txt4.29 KB
add_testcoverage_for-2894637-16.patch17.91 KB

17kb of mostly test-coverage, this makes me very happy!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Dazzle commented
Status: Needs review » Fixed

Committed and pushed, followup in #2872404: Use native facet range queries with solr

  • borisson_ committed 33f383d on 8.x-1.x 
    Issue #2894637 by borisson_, agoradesign: Add testcoverage for range +...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.